Repository navigation
Pipe utils - #112
Merged
Merged
Pipe utils#112
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
A critical tuple-path loading defect and several moderate pipeline behavior issues remain unresolved.
Review effort: Lite
Findings: 1
Open (3)
What changed in this PR
This PR adds pipeline node controls and tuple-path support for datablock utilities, while consolidating utility tests.
Changes:
- Adds persistent skip flags and node parameter setters by index or name.
- Supports nested datablock paths in utility nodes.
- Consolidates utility tests and updates documentation.
| File | Summary |
|---|---|
agrifoodpy/utils/tests/test_write_to_disk.py |
Reviewed consolidated utility test coverage. |
agrifoodpy/utils/tests/test_write_to_datablock.py |
Reviewed consolidated utility test coverage. |
agrifoodpy/utils/tests/test_print_datablock.py |
Reviewed; nested tuple-path coverage remains needed. |
agrifoodpy/utils/tests/test_nodes.py |
Consolidates utility node tests. |
agrifoodpy/utils/tests/test_load_dataset.py |
Reviewed; nested output-path coverage remains needed. |
agrifoodpy/utils/tests/test_copy_datablock.py |
Reviewed; nested key and output-path coverage remains needed. |
agrifoodpy/utils/tests/test_add_years.py |
Reviewed consolidated utility test coverage. |
agrifoodpy/utils/tests/test_add_items.py |
Reviewed consolidated utility test coverage. |
agrifoodpy/utils/nodes.py |
Adds tuple-path handling; standalone dataset loading has an unresolved tuple-path lookup issue. |
agrifoodpy/pipeline/tests/test_pipeline.py |
Tests pipeline configuration APIs. |
agrifoodpy/pipeline/pipeline.py |
Adds skip and parameter controls; numbering, CLI name handling, and boolean validation require changes. |
agrifoodpy/land/model.py |
Clarifies a function docstring. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
This PR introduces new pipeline management utilities, and fixes to existing datablock manipulation functions:
print_datablockandcopy_datablocknode functions not use the right dictionary manipulation utilities to correctly take datablock path tuples as inputs.Checklist