You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi @Fithi-Teklom - your TV show project links (both the netlify and the git repo) aren't correct. The netlify one probably goes to a list of your projects, but doesn't work for me because I'm not logged in as you. The repo link is a link to all of your repos, not to your actual single repo. Please update them and reply on this issue when you have :)
Hi @Fithi-Teklom - your TV show project links (both the netlify and the git repo) aren't correct. The netlify one probably goes to a list of your projects, but doesn't work for me because I'm not logged in as you. The repo link is a link to all of your repos, not to your actual single repo. Please update them and reply on this issue when you have :)
HI illicitonion Thank you for the feedback, I believe I have fixed the issues now.
I'm going to approve your step (congratulations!), but here are a few things to think about in your implementation:
It seems strange that you'd have both showShowsError and showShowsError functions (same with the show loading functions) - these feel like they could be shared?
I'm going to approve your step (congratulations!), but here are a few things to think about in your implementation:
It seems strange that you'd have both showShowsError and showShowsError functions (same with the show loading functions) - these feel like they could be shared?
Activity
[-]Manchester| Data flows | Fithi-Teklom[/-][+]25-ITP-SEP| Data flows | Fithi-Teklom[/+]illicitonion commentedon Dec 21, 2025
Hi @Fithi-Teklom - your TV show project links (both the netlify and the git repo) aren't correct. The netlify one probably goes to a list of your projects, but doesn't work for me because I'm not logged in as you. The repo link is a link to all of your repos, not to your actual single repo. Please update them and reply on this issue when you have :)
Fithi-Teklom commentedon Dec 21, 2025
HI
HI illicitonion Thank you for the feedback, I believe I have fixed the issues now.
illicitonion commentedon Dec 21, 2025
Hi Fithi! Thanks for fixing!
I'm going to approve your step (congratulations!), but here are a few things to think about in your implementation:
showShowsErrorandshowShowsErrorfunctions (same with the show loading functions) - these feel like they could be shared?innerHTMLwith untrusted input: Have a read of https://medium.com/@sparklewebhelp/understanding-the-risks-of-using-inner-html-in-web-development-30d4fa67f815 and see if you can fix itBut everything is looking great, well done!
Fithi-Teklom commentedon Dec 21, 2025
Thank you so much for your feedback,I am so grateful. And for sure I am going to fix the small issues and learn my lessons!