Skip to content
This repository was archived by the owner on Aug 17, 2026. It is now read-only.

Bug-53.4: World Info before join world - #126

Merged
nikorsanchez merged 3 commits into
mainfrom
bug-53/world-info
May 29, 2026
Merged

nikorsanchez merged 3 commits into
mainfrom
bug-53/world-info

Conversation

@agustinbarbalase

Copy link
Copy Markdown
Contributor

Changes:

  • Added ActivePlayersResponse DTO with active_players and average_player_time fields
  • Added GetActivePlayers(worldId) method that hits GET /orchestrator/{worldId}/players and returns the active player count
  • Added ParseUtcTimestamp helper that parses ISO timestamp strings into UTC DateTime, defaulting to DateTime.MinValue on failure
  • Populated created_at and created_by fields on ActiveWorldData.worldData using the new timestamp parser and world.user_id

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds world metadata needed before joining a world, including active-player lookup support and created-by/created-at population for active world listings.

Changes:

  • Added GetActivePlayers(worldId) endpoint wrapper.
  • Added ActivePlayersResponse DTO.
  • Populated created_at and created_by for ActiveWorldData.worldData.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
Runtime/Core/Systems/API/WorldService.cs Adds active-player API call and UTC timestamp parsing for active world metadata.
Runtime/Core/Systems/API/DTOs/WorldDTOs.cs Adds DTO for the active-player response payload.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Runtime/Core/Systems/API/WorldService.cs
@nikorsanchez
nikorsanchez merged commit 7bc3047 into main May 29, 2026
4 checks passed
@nikorsanchez
nikorsanchez deleted the bug-53/world-info branch May 29, 2026 20:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants