This repository was archived by the owner on Aug 17, 2026. It is now read-only.
Repository navigation
US-80: Change color of sprites - #119
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds HSV-based character color customization (skin/hair/eyes) to the Character Edit UI and propagates these colors through API DTOs, persistence repositories, and sprite rendering so characters can be tinted consistently.
Changes:
- Introduces HSV color DTOs on character requests/responses and threads them through player/editor repositories.
- Adds a new color-controls UI flow in
CharacterEditController(dropdown + HSV sliders) with save/reset integration. - Extends sprite loading/rendering to apply tinting to skin, hair, and eyes across character parts.
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Runtime/UI/CharacterEdit/Scripts/CharacterEditController.cs | Initializes color controls, persists HSV fields into the edit request, and applies colors during setup. |
| Runtime/UI/CharacterEdit/Scripts/CharacterEditController.Actions.cs | Wires color tab selection, ensures color fields before save, applies colors after loads/saves/resets. |
| Runtime/UI/CharacterEdit/Scripts/CharacterEditController.Colors.cs | New partial implementing HSV UI controls, request synchronization, and sprite color application. |
| Runtime/UI/CharacterEdit/Scripts/CharacterEditController.Colors.cs.meta | Unity meta for the new partial class file. |
| Runtime/Models/Creatables/NPCData.cs | Adds default HSV color fields to NPC creatable data. |
| Runtime/Models/Creatables/EnemyData.cs | Adds default HSV color fields to enemy creatable data. |
| Runtime/Core/Systems/Enums/CharacterPartCategory.cs | Adds new skin-part enum entries used for tinting. |
| Runtime/Core/Systems/Characters/SpriteManager/SpriteManager.cs | Adds public APIs to apply skin/hair/eye colors and applies them on init from character info. |
| Runtime/Core/Systems/Characters/SpriteManager/SpriteLoader.cs | Implements per-part tint application and caches skin part transforms. |
| Runtime/Core/Systems/Characters/CharacterInfoRepository/PlayerInfoRepository.cs | Includes HSV fields when saving player character info via repository abstraction. |
| Runtime/Core/Systems/Characters/CharacterInfoRepository/EditorNpcInfoRepository.cs | Updates editor callback to return full response including colors; includes HSV fields in response. |
| Runtime/Core/Systems/API/DTOs/PlayerInfoDTOs.cs | Adds CharacterColorHsv DTO and includes it in patch request and response models. |
Files not reviewed (1)
- Runtime/UI/CharacterEdit/Scripts/CharacterEditController.Colors.cs.meta: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
US-80 PR bundle: