Fix the :add-package command by not using variable parsing from .\build.ps1

[ITaluone]

The Join-Path actually prevents to use the gloabl tool's :add-package command, since this command greps the build.csproj path from the .\build.ps1. ./build.sh is not affected, since there is no such "fancy" command to "just" join paths :).

Fixes: #670

[ChrisonSimtian]

ah this old chestnut ... io ops in ps1 is a massive pain, thanks for fixing this

[ITaluone]

ah this old chestnut

Why old? I reverted to the actually "old" ;)

[ChrisonSimtian]

ah we use psake at work and the amount of times i fixed this is countless 😂🙈 thats why its an old cheatnut for me. I find this and other things in powershell very brittle, the only advantage over bash is it can natively use dotnet code

[ITaluone]

I hate powershell as well :)

For example: simple tools like curl regularly freaking me out, because it is a pain on powershell (which is the "default" terminal on win11). Using good old cmd works like a charm :D

[ITaluone]

Ah.. just read the commit message for 7a30bc5.

I try if this is a problem again.

Edit: I tried with forward slashes on windows, for PS v5.1 and PS v7.6.6.. Both worked, and could handle the forward slashes.
I assume this works on unix, too. (I actually cannot imagine why using pwsh on unix since bash is better.. but ok..)

[ChrisonSimtian]

Ah.. just read the commit message for 7a30bc5.

gotcha, might just have to try and tell ps1 to use the latest v7 not the legacy v5
iirc then MS actually wants to retire it (same as net framework) but keep it semi-alive for legacy reasons.

which is the "default" terminal on win11
man I feel so much better since I use a macbook as my personal device and run WSL on my win11 work laptop (thanks to claude cli being crap on windows pty :-) ) I even run a LXC on my homelab just for coding. But then energy prices in NZ are not even half of what I used to pay in Germany 10 years ago (and those went up by now by what factor 2?)

[ITaluone]

@ChrisonSimtian Why the powershell $BuildProjectFile = "$PSScriptRoot/build/_build.csproj" is missing in this repo completely? This is needed for the :add-package command.

[ChrisonSimtian]

@ChrisonSimtian Why the powershell $BuildProjectFile = "$PSScriptRoot/build/_build.csproj" is missing in this repo completely? This is needed for the :add-package command.

$BuildProjectFile = "$PSScriptRoot/_BUILD_DIRECTORY_/_BUILD_PROJECT_NAME_.csproj"
isnt that what you're adding here?

[ITaluone]

No? that's the template.

I am adding this there, because consumer need it.

I asked why this repo doesn't have this in the .\build.ps1 (aka was removed intentionally?)

Edit: PR #204 removed this, from the template as well as from the "own" .\build.ps1

[ChrisonSimtian]

Edit: PR #204 removed this, from the template as well as from the "own" .\build.ps1

correct, and replaced it with the cli call instead in an attempt to make the powershell script as thin as possible.
the linux version is the same btw.

I dont mind you adding it back if its needed but ultimately i'd really like to move away from .ps1 and .sh towards a pure dotnet cli. So its probably better to build that in natively rather than relying on ps1/sh to pass things through

[ITaluone]

Ok then.. should this be a follow-up? or should I change the PR to not depend on the bootstrapper files at all?

Your call @ChrisonSimtian

Edit: The problem is, that the user can name the build project file and folder like he wants. We only give a suggestions as default.
So, as long as the user can choose own names we have to write this names somewhere down. And having yet another file for this mapping, I cannot see the advantage compared to what used to work.

[ITaluone]

Ok.. think I have a solution to this:

A Fallout build project always have this custom MSBuild variables set like: <FalloutRootDirectory> or <FalloutScriptDirectory>.

I will change the AddPackageCommand to basically make a grep -R FalloutRootDirectory *.csproj. If you want, I can introduce a dedicated variable like <IsFalloutBuildProject> or similar.

[ChrisonSimtian]

Ok.. think I have a solution to this:

A Fallout build project always have this custom MSBuild variables set like: <FalloutRootDirectory> or <FalloutScriptDirectory>.

I will change the AddPackageCommand to basically make a grep -R FalloutRootDirectory *.csproj. If you want, I can introduce a dedicated variable like <IsFalloutBuildProject> or similar.

lets make a gh issue for this and discuss there independently from this PR. Not in the right headspace for this at the moment, sorry