Install the Node toolchain before promoting - #30
Merged
Merged
Conversation
Both promotion jobs failed resolving vsce and ovsx. --skip PackVsix prunes the whole upstream chain, RestoreVsix included, because nothing else needs it — so npm ci never ran and the CLIs, being dev dependencies, were simply absent. It failed before reaching either registry, so nothing was published and the version was not consumed. Only a real promotion could surface this; every rehearsal so far stopped at the approval gate. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
|
Warning Review limit reachedNext included review available in 21 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first real promotion of v10.4.31 failed in both marketplace jobs:
Cause
--skip PackVsixprunes the entire upstream chain —RestoreVsix(npm ci) included, since nothing else needs it.vsceandovsxare dev dependencies andIHasVsix.ResolveNodeToollooks innode_modules/.binbeforePATH, so with nonode_modulesthe tools are absent and the target dies resolving them.Fix
npm ciin both promotion jobs, before the build step. The jobs already configuresetup-nodewith npm caching, so it costs seconds. This is toolchain provisioning, which is the layer the workflow is for — the publish itself stays a Fallout target.Recorded in
docs/ci.mdalongside the other CI gotchas.Impact
Nothing was published and 10.4.31 was not consumed — it failed before contacting either registry. Verified: Open VSX namespace still empty, VS Marketplace query returns zero extensions. The same tag can be promoted again once this lands.
Only a real promotion could have caught this; every rehearsal stopped at the approval gate, which is upstream of the failure.