Release 10.4.31 - #29
Merged
Merged
Conversation
Squash into develop, rebase into main. GitHub cannot enforce a method per branch, so this is written down rather than configured; both methods stay enabled because both are correct somewhere. Also records why rebasing between two long-lived branches is safe, since it is a fair thing to worry about: rebase-merge rewrites commits, so main never becomes an ancestor of develop, and after a hotfix has been ported back the merge base falls behind both. The next release therefore *looks* like it would replay commits already on main. It doesn't — git rebase drops already-applied commits by patch-id. Verified rather than assumed: after a release, a hotfix on main and a cherry-pick back to develop, rebasing develop onto main listed three candidate commits and replayed exactly one. The edge case is documented too: a port-back that was conflict-resolved differently no longer matches by patch, so rebase will retry it. That shows up as a conflict at release time, which is visible and fixable rather than silent. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
One canonical AGENTS.md, read natively by GitHub Copilot, with CLAUDE.md as a pointer that imports it — matching the framework repo so contributors and tooling meet one convention across both. Adds CONTRIBUTING.md, a shared issue-and-PR style contract, issue templates, and the repo's Claude Code config. Adapted rather than copied: the merge model differs here, so the commit-restructuring skill now reads the PR's base ref and stops on develop-bound PRs, where squash makes commit curation pointless. Ignores *.local.* so machine-local state can't be committed. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
The forms asked for "triage", but the label is "needs-triage" — so GitHub silently dropped it and every templated issue arrived untriaged. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
Matches the framework repo's, so the same read-and-build commands run without a prompt in either checkout. Adds the npm toolchain, since compiling and packaging this extension goes through npm rather than pwsh alone. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
The repo had no .vscode/launch.json, so pressing F5 — the standard way to run a VS Code extension — did nothing, and running it from source meant knowing to pass --extensionDevelopmentPath by hand. Adds two launch configurations that compile first, so the Extension Development Host never loads a stale build, plus docs/developing.md covering the loop and the two behaviours that otherwise read as bugs: the empty Deployment view, and package.json's deliberate 0.0.0. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
Co-authored-by: Claude Opus 5 <[email protected]>
Co-authored-by: Claude Opus 5 <[email protected]>
Co-authored-by: Claude Opus 5 <[email protected]>
Co-authored-by: Claude Opus 5 <[email protected]>
Co-authored-by: Claude Opus 5 <[email protected]>
Co-authored-by: Claude Opus 5 <[email protected]>
Co-authored-by: Claude Opus 5 (1M context) <[email protected]>
An immutable release reserves its tag permanently, so deleting the release and the tag did not free the name — the channel had been unable to publish since 16 August and `preview` is unusable in this repo forever. Records why in the workflow header and the CI docs, including that the conflict is structural: one tag force-moved on every push is what immutability forbids, so per-commit tags are the answer if it is ever needed here, not a third name. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
The README is the marketplace page and still described the pre-August extension. Rewrites it against what ships, with four screenshots from a real Extension Development Host. Gates the Deployment view behind fallout.deployment.enabled, off by default — no released framework emits a deployment graph, so it can only show a placeholder. Adds a gallery banner in the social preview's colours, and clears all seven dependency advisories within their existing ranges. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
|
Warning Review limit reachedNext included review available in 36 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: ⛔ Files ignored due to path filters (7)
📒 Files selected for processing (28)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ChrisonSimtian
temporarily deployed
to
github-releases
September 9, 2026 01:11 — with
GitHub Actions
Inactive
ChrisonSimtian
had a problem deploying
to
vs-marketplace
September 9, 2026 01:14 — with
GitHub Actions
Failure
ChrisonSimtian
temporarily deployed
to
github-releases
September 9, 2026 01:14 — with
GitHub Actions
Inactive
ChrisonSimtian
had a problem deploying
to
open-vsx
September 9, 2026 01:14 — with
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First release. Everything on
developsince the GitFlow adoption.What ships
AGENTS.mdas the canonical brief, contributing guide and issue templates, the rolling channel renamed tonightly, all dependency advisories cleared.Merge method
Rebase, not squash — squashing collapses the whole release into one commit on the production branch and loses the per-change history. See docs/branching-and-release.md.
After merge
Tag
v10.4.31onmain— the numbernbgvcomputes for this commit. That firespublish.yml, which packs and creates the GitHub release. No marketplace publish: that needs a separate dispatch withpublish-to-marketplaces=trueplus environment approval.