Repository navigation
Add read-only feed-readback workflow for published Governance tool versions (Refs #423) - #473
Merged
Merged
Conversation
…rsions (Refs #423) Manual dispatch with contents/packages read only: downloads FS.GG.Governance.Cli and FSharpSurfaceCommand at one exact version from the org feed (run token) and nuget.org, records SHA-256 and compares every archive entry, excepting only nuget.org's .signature.p7s. Builds, pushes and tags nothing. Co-Authored-By: Claude Opus 5.5 <[email protected]>
…ository commit (Refs #423) Co-Authored-By: Claude Opus 5.5 <[email protected]>
Contributor
Author
|
fdev: relaying the independent fsgg-critic-best (opus) review of PR #473. Head 68d7bbb: ACCEPT, with only low-severity findings. The reviewer ran the extracted step against the real 1.14.0 packages, with the org copy simulated:
Head 45da5eb: ACCEPT. This head applies findings 1 and 4:
The fixture matrix was re-run: the duplicate case now fails, and the 1.14.0 commit Still open:
CI: 15/15 checks pass on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #423. This links the issue without closing it. It supports the post-publication acceptance of Governance 1.15.0: condition 4 of the GO comment calls for a cold install from both feeds and a byte comparison, signature excepted.
Why
The session's token cannot read the org GitHub Packages feed; it gets 403 on both the download and the packages API. The standing rule is no new credentials. The publish run (39928935417) uploaded no package artifacts, so the org-feed bytes can only be read with a workflow's own run-scoped token. The only existing readback is the Config-only recovery route inside
publish.yml, which is the publishing workflow and ties readback to artifact recovery, so it was not reused.Change
Adds one new file,
.github/workflows/feed-readback.yml.workflow_dispatchonly, with a single input: an exact SemVerversion, validated.contents: read,packages: read. Nothing is checked out and nothing is built.FS.GG.Governance.CliandFS.GG.Governance.FSharpSurfaceCommandat the selected version fromhttps://nuget.pkg.github.com/FS-GG, using the run'sGITHUB_TOKEN..signature.p7s.282741b1.readback.jsonandsha256sums.txtas a 30-day artifact.Planned use
After merge, dispatch once with
version=1.15.0, as admitted by the coordinator. The result goes on #423 as acceptance evidence.Review
An independent fsgg-critic-best review accepted
68d7bbbewith only low-severity findings. This head applies two of them: duplicate-name refusal and the nuspec commit record.Checks
bash -npasses on the step script.actions/upload-artifact@v7follows the repository's existing usage.architecture-map: unaffected
🤖 Generated with Claude Code