Repository navigation
Import skill: what the first real backfill taught; CORI school-year expiry (#65) - #70
Merged
Merged
Conversation
The first real run, a backfill of 13 minimally-entered students, worked end to end and checked clean. It also showed what the skill got wrong: - The Drive connector returns only each tab's header and first 10 rows, so the full read is now an .xlsx download, read by read_xlsx.py (standard library only) from the scratchpad and deleted afterwards. Completeness is checked against the plan's people count. - Every block goes on the clipboard with pbcopy and is checked with pbpaste, since tabs copied out of a chat code block can become spaces. - Fills go in blank rectangles over consecutive rows, checked by Person ID on the first and last rows, instead of one row at a time. - Each pass ends on a fresh download compared with the previous one across the whole workbook, cell by cell. - The baseline also records the groups dry run, so a join that was already pending (one turned up) isn't taken for the import's own. - No rule splits every name of three or more words, so each one is confirmed; an operator-approved correction of an existing value is a write of its own; deploy before the baseline. - mapping.md gains Format E's team-added columns (CORI check dates are dates to get, never an expiry) and the conventions the earlier rows followed: grade to year, skill synonyms, note wording. Co-Authored-By: Claude Opus 5.5 <[email protected]>
The team's rule, settled during the first backfill: a CORI check covers the school year it was done in (July to June) and the next two, and its expiry is entered as 1 September after the third, about the first day of school. A summer check counts toward the coming school year. That puts a summer check's expiry up to two months past three years, and hawk-mod read anything past three years as a typo, so a mentor checked in July would have lost access. latestCoriExpiry allows the 1 September and is never earlier than three years, so nothing current before reads as a typo now. It replaces the plain bound in screeningStatus, mayHaveAccess and screeningEntryErrors. lifecycle-sheet.md now says what "never calculated" meant all along: the sheet stores the expiry, which is what everything triggers on. The CORI rule is the one expiry worked out, when it is entered. The import skill shows each one as a derived value. Co-Authored-By: Claude Opus 5.5 <[email protected]>
willtoth
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #65. The skill has now been used for one real run, its dry-run outputs were checked against the approved table, and this PR fixes what it got wrong.
The run (2026-10-15)
It was a backfill of the 13 students who had been entered with only enough to get them into Slack, filled from the 2026-27 registration form's responses:
After each pass, the whole workbook was compared cell by cell with the download before it. Every intended cell held the approved value, and nothing else changed. The dry runs matched the plan:
planidentical to the baseline;grp-parentsfrom 65 to 88, made 1 roster name update, and changed nothing else.One pending
grp-parentsjoin turned out to predate the run.What the skill got wrong, now fixed
read_file_contentreturns only each tab's header and first 10 rows;Peoplehas 80. Gate 1's completeness check caught it. The read is now an.xlsxdownload, read by the newread_xlsx.py(Python standard library only) from the session scratchpad and deleted afterwards. Completeness is checked against the plan's people count.pbcopyand is checked withpbpaste. Tabs copied out of a chat code block can turn into spaces./hawkmod lifecycle groups, so a join that was already pending isn't taken for the import's own.mapping.md, Format E. It gains the columns the team added (CORI parent?holds the date a check was done, so it's a date to get and never an expiry), and the conventions the earlier rows followed: grade to year, skill synonyms, note wording.The skill files were checked against every name, email and phone number in the sheet and the responses: none appears.
CORI expiry: three school years, ending 1 September
This rule was settled during the run. A CORI check covers the school year it was done in (July to June) and the next two, and its expiry is entered as 1 September after the third, about the first day of school. A check done over the summer counts toward the coming school year.
latestCoriExpiry(rules/screening.ts) allows that 1 September, and is never earlier than three years, so nothing that was current before reads as a typo now. It replaces the plain bound inscreeningStatus,mayHaveAccessandscreeningEntryErrors.lifecycle-sheet.md§2 now says what "never calculated" meant all along: the sheet stores the expiry, which is what everything triggers on. The CORI rule is the one expiry worked out, and it's worked out when it's entered.Verification
npm run typecheck && npm test && npm run format:checkpass (857 tests, 2 of them new, for the summer CORI bound).🤖 Generated with Claude Code