Skip to content

Restore Workers tests after the Vitest 5.1 upgrade - #302

Merged
admdly merged 3 commits into
mainfrom
codex/fix-ci-tests
Nov 5, 2026
Merged

admdly merged 3 commits into
mainfrom
codex/fix-ci-tests

Conversation

@admdly

@admdly admdly commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Vitest 5.1.0 breaks mocked imports in the Workers test runtime with asyncLocalStorage.disable() is not implemented, failing 30 test files on main and the Renovate branches. Restore Vitest and Istanbul coverage to 5.0.5, using the last passing lockfile, and temporarily constrain Renovate to versions below 5.1.0.

Cloudflare's pending 1.6.1 release includes the upstream fix. Version 1.6.1 is not yet available on npm as of 5 November 2026, 20:14 UTC; fresh registry lookups return 404. Once published, upgrade @cloudflare/vitest-plugin to 1.6.1 or later, restore Vitest and Istanbul coverage to 5.1.0, and remove the temporary Renovate rule. The latest published plugin (1.6.0) still reproduces the failure.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
api a082019 Nov 05 2026, 08:23 PM

@admdly admdly self-assigned this Nov 5, 2026
@admdly
admdly marked this pull request as ready for review November 5, 2026 20:18
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review ✅ Completed 2026-11-05T20:20:48.814619Z ab4f9f9 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 4 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread .github/workflows/ci.yml Resolved

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 1 file (changes from recent commits).

Auto-approved: Rolls back Vitest and @vitest/coverage-istanbul to the last passing 5.0.5 lockfile and constrains Renovate below 5.1.0 until the Workers plugin fix is published; this is a bounded rollback of a broken upgrade that restores failing Workers tests.

Turn on auto-fix | Re-trigger cubic

@admdly
admdly merged commit e7076fb into main Nov 5, 2026
9 checks passed
@admdly
admdly deleted the codex/fix-ci-tests branch November 5, 2026 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant