Repository navigation
Fix central-alerts cache-reuse test for Hono encoded query order - #289
Merged
Merged
Conversation
Hono 4.13.14 (honojs/hono#5495) fixed req.query() skipping an earlier encoded duplicate, so ?%6cimit=2&limit=1 now resolves to limit=2 (first-wins in string order) instead of limit=1. Update the ?limit=1 cache-reuse variants to use encoded-first value 1, and add a ?limit=2 case locking the corrected duplicate resolution.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
api | ba1e884 | Oct 30 2026, 09:39 AM |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
No issues found across 1 file
Auto-approved: Updates a central-alerts cache-reuse test to match Hono 4.13.14's first-wins resolution of encoded duplicate query params. Test-only change; no app code, API, or operational behavior changes.
Turn on auto-fix | Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI (
test/services/central-alerts/v1/index.test.ts>should reuse the effective page for ?limit=1) fails onmainand on #287 withexpected 500 to be 200.Root cause is the Hono 4.13.14 upgrade (#286): honojs/hono#5495 fixed
req.query(key)skipping an earlier encoded duplicate, so?%6cimit=2&limit=1now resolves tolimit=2(first-wins in string order) instead oflimit=1. The test had locked the old, buggy framework behavior; the app itself maps every effective page to exactly one normalized cache key, so no app-code change is needed.?limit=1group:?%6cimit=2&limit=1replaced with?%6cimit=1&limit=2?limit=2group locks the corrected duplicate resolution (?%6cimit=2&limit=1,?limit=2.0)