Repository navigation
uxplay: don't lose a /play that arrives while the video renderer is rebuilt - #599
Open
danieldhaiti wants to merge 1 commit into
Open
danieldhaiti wants to merge 1 commit into
danieldhaiti wants to merge 1 commit into
Conversation
…ebuilt Restart requests (url, relaunch_video, reset_loop, preserve_connections, reset_httpd, close_window, full_video_reset) are posted from the http, mirror and main threads, but main_loop() cleared them on entry. A /play arriving while the main thread rebuilt the renderer was silently dropped and the HLS renderer never built. Post the requests under one recursive lock and consume them only once, in take_restart_request(), after main_loop returns.
fduncanh
force-pushed
the
master
branch
3 times, most recently
from
October 22, 2026 00:44
f0cd2c3 to
26be3d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restart requests (url, relaunch_video, reset_loop, preserve_connections, ...) are posted from the http, mirror and main threads, but
main_loop()cleared them on entry. A/playthat arrived while the main thread was rebuilding the video renderer was silently dropped, and the HLS renderer was never built (seen with the YouTube app: a mirror teardown followed ~0.3 s later by/play).Post the requests under one recursive lock and consume them only once, in
take_restart_request(), aftermain_loopreturns.main_looppicks mirror vs HLS from a newvideo_renderer_is_hls().Tested: builds on Ubuntu (GStreamer 1.28, Release) with no new warnings. A scripted
/playA then/playB 0.2-0.4 s later reproduces the lost request on master (1 player built) and is honored with this patch (2 built). 200 concurrent/stoprequests: no crash, clean SIGTERM exit.