Fix parsing mapgen options - #1165
Conversation
passing "--" before option name works both with default
option names and their aliases
but if an alias is removed -- nothing we can do, we'll
have to manually fix parsing again as we do now
("texture-styles" became an alias and "biomes" is the new default)
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe MapGenerator extractor now passes prefixed option names, removes the prefix from stored results, and refreshes options before missing-version extraction. The isort pre-commit hook revision changes from 8.0.1 to 9.0.1. ChangesMap generator option handling
Tooling revision
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 1 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary by CodeRabbit
Bug Fixes
Chores