fix: render volume sliders on mobile/touch devices (iOS) - #721
Merged
Merged
Conversation
The volume sliders for lines and PGM were hidden on iOS phones and iPads because UserControls gated the <VolumeSlider> behind `!isIOSMobile && !isIpad`. Volume is applied to audio elements independently of this UI guard, so the slider is functional on these devices; the guard only hid the control. Remove the mobile/touch guard (keeping the program-user-on-program-output-line guard) so the sliders render everywhere, and add a regression test. Co-Authored-By: Claude Opus 4.8 <[email protected]>
Contributor
Author
|
code-reviewer verdict: LGTM (automated self-review; recorded as a marker because GitHub blocks state-bearing self-review when author and reviewer are the same account). Small, well-scoped fix for #621. Removing the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/components/production-line/user-controls.tsxwas gated behind!isIOSMobile && !isIpad, hiding it on all touch devicesbowserimport) so the slider renders on mobile/touch as welluser-controls.test.tsxTest plan
npm test) — 322 testsnpm run typecheck)npm run lint)Closes #621
🤖 Generated with Claude Code