Skip to content

Fix retired option verification with noisy WP-CLI output - #564

Merged
chubes4 merged 3 commits into
mainfrom
fix/563-noisy-option-verification
Sep 1, 2026
Merged

Fix retired option verification with noisy WP-CLI output#564
chubes4 merged 3 commits into
mainfrom
fix/563-noisy-option-verification

Conversation

@chubes4

@chubes4 chubes4 commented Sep 1, 2026

Copy link
Copy Markdown
Member

Summary

  • probe retired Homeboy option absence through wp eval exit status instead of parsing wp option list output
  • use an identity-safe sentinel so every persisted option value remains distinguishable from absence
  • retain fail-closed behavior when WordPress cannot verify state
  • cover diagnostic text emitted on stdout

Verification

  • bash tests/integration-adapters.sh
  • bash -n lib/integration-adapters.sh tests/integration-adapters.sh
  • live PHP 8.5/WP-CLI probe returned success while deprecation diagnostics were emitted

Closes #563.

AI assistance

OpenAI GPT-5.6 Sol via OpenCode diagnosed the live upgrade failure, implemented and verified the focused repair, and orchestrated the tracked worktree, commit, and PR submission.

@chubes4
chubes4 merged commit 7fcd849 into main Sep 1, 2026
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix option cleanup verification with noisy WP-CLI stdout

1 participant