Repository navigation
Leave-by times start from home on the Contacts card - #30
Merged
Merged
Conversation
The owner chose home as the starting point, read from his own Contacts card. eta_from now takes contacts:home (or contacts:work), resolved each run through a new read-only ek me-address, so the address is never saved and stays right after a move. A card with no home address gives a note and no trips. Tested against a real card and Apple Maps, printing only a yes and the minutes; three new tests. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Owner, relayed by Simon (2026-11-15): "Home (Recommended)", read from his Contacts "me" card, kept out of the repo, and said in check-ins if the card has none.
ek me-address [--label home|work]: reads My Card through the Contacts framework, read only. Prints{"found": false, "reason": ...}when there's no My Card or no address with that label.eta_from: "contacts:home": resolved on every run, so the address is never written to config, cache or repo. A missing address gives a note ("No leave-by times: your Contacts card has no home address. Add it to your card in Contacts.") and no lookups.Tested:
ek me-addressagainst the real card (found an address, printed only yes/no), then a real Apple Maps ETA from it (printed only minutes). 15 eta tests pass, including the card, a missing address and the address never being saved;ci-checks.shpasses.🤖 Generated with Claude Code