Repository navigation
Dock icon, every Quit really quits, release 0.6.5 - #27
Merged
Merged
Conversation
…e 0.6.5 The owner couldn't replace Theseus.app because it was still in use after Quit. Quit killed `script`, but `script` runs `claude remote-control` in a session of its own, so it kept running. Quit now stops the whole process tree, SIGTERM first and SIGKILL after three seconds, and a backstop exits the app after eight seconds if anything holds Quit up. Tested: a new macOS test where the child ignores HUP and TERM, the CI checks, and a debug build with a stand-in claude: before the fix the stand-in outlived Quit, after it nothing was left. Not tested: a real Remote Control session. Co-Authored-By: Claude Opus 5.5 <[email protected]>
The owner asked for Theseus in the Dock with a Quit like LeafJuice's (2026-11-15). Theseus is now always a regular app: no LSUIElement, no accessory switching. Every way out goes through one Quit: the Dock's Quit and logout arrive as Exit without ExitRequested, so Exit now leaves the marker too, and ExitRequested (Cmd-Q) runs the full Quit. Quit work runs off the main thread so the window can save. Tested: unit tests for the marker and the Dock icon; sandbox runs with a stand-in claude for Cmd-Q and a quit Apple event (3 of 3), each leaving the marker and no process; a bundled build kept its Dock icon with the window closed. Not tested: clicking the menu bar icon's Quit. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The owner couldn't install 0.6.4: Theseus.app stayed in use after Quit. Quit killed
script, butscriptrunsclaude remote-controlin its own session, so it survived.Tested: new macOS test
stopping_remote_control_leaves_no_process_behind(child ignores HUP and TERM),scripts/ci-checks.sh, and a debug build with a stand-in claude in a sandbox: before the fix the stand-in outlived Quit; after it, nothing was left.Not tested: a real Remote Control session.
🤖 Generated with Claude Code