Repository navigation
Standard Mac menu bar with Quit, release 0.6.4 (D211) - #26
Merged
Merged
Conversation
…(D211) The owner found no way to quit Theseus from its window: as a menu bar app it had no app menu. While the window is open Theseus is now a regular app with a Dock icon and Theseus, Edit and Window menus (About, Settings…, Hide, Quit on Cmd-Q). Closing the window returns it to the menu bar. Quit from the app menu uses the same path as the menu bar icon's Quit. Tested: cargo tests for the menu contents and ids, the CI checks, and a debug build on an empty workspace (menus present, Close Window returns it to the menu bar, Quit exits and leaves the quit flag). Not tested: Settings… opening Setup on screen, and Open Theseus from the menu bar icon. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the owner's report (D211): the Theseus window had no menus, so there was no way to quit from inside the app.
Tested: two new cargo tests (menu contents, ids don't clash with the tray),
scripts/ci-checks.sh, and a debug build on an empty workspace, checked through System Events: menus present, Quit has Cmd-Q, Close Window returns it to the menu bar, Quit exits and leaves the flag.Not tested: Settings… switching to Setup on screen; Open Theseus from the menu bar icon (same function as the first-launch path, which was tested).
🤖 Generated with Claude Code