Repository navigation
fix: add hasEligibleTokenizationTarget to Android paper spec - #135
Merged
JakubKorytko merged 3 commits intoOct 29, 2026
Merged
Conversation
JakubKorytko
marked this pull request as ready for review
October 29, 2026 10:28
melvin-bot
Bot
requested review from
marcochavezf
and removed request for
a team
October 29, 2026 10:30
marcochavezf
approved these changes
Oct 29, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
WalletModule.ktoverrideshasEligibleTokenizationTarget, but the old architecture spec (android/src/paper/.../NativeWalletSpec.java) never declared it. WithnewArchEnabled=falsethe Android build fails:It came in with the UAPP change (PR 75) and is in the published 0.2.x versions, so any app still on the old architecture can't build Android. New architecture apps are not affected, codegen generates the spec from
src/NativeWallet.ts.This adds the missing abstract method, in the same position as in
src/NativeWallet.ts.It also restores
@ReactMethodand@DoNotStriponactivateAppleWalletPassandIOSFailAddPaymentPass. They were dropped while resolving merge conflicts. Both are iOS only, so nothing calls them on Android, but every other method in the spec has the annotations.Related Issues
None
Manual Tests
In
apps/basic-example/android, compile the library module on both architectures:Before: the old architecture build fails with the error above. After: both succeed.
Linked PRs
None