Repository navigation
Bump form-data to 4.0.6 to address Dependabot alerts - #882
Merged
Merged
Conversation
Co-authored-by: Chuck Dries <[email protected]>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
chuckdries
approved these changes
Oct 29, 2026
melvin-bot
Bot
requested review from
mjasikowski
and removed request for
a team
October 29, 2026 18:32
mjasikowski
approved these changes
Oct 30, 2026
Contributor
|
@mjasikowski looks like this was merged without a test passing. These checks had not passed on cd8da84 when it was merged:
Please add a note explaining why this was done and remove the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Fixes the two open
form-dataDependabot alerts by bumpingform-datafrom 4.0.3 to 4.0.6 inpackage-lock.json:Usage: dev-only and transitive, through
jest-environment-jsdom→[email protected], which requiresform-data@^4.0.0. Nothing ships in the published package.Why only the lockfile changes: 4.0.6 already satisfies
jsdom's^4.0.0range, so nooverridesentry is needed.[email protected]requireshasown@^2.0.4, sohasownalso moves from 2.0.2 to 2.0.4. Every other dependent asks forhasown@^2.0.2, so that bump is compatible. Both versions were published more than 7 days ago, which satisfiesmin-release-age=7in.npmrc. The versions, tarball URLs, and integrity hashes come from the npm registry metadata.Note: Melvin couldn't run
npmin its environment, so it edited the two lockfile entries by hand. Please confirm that CI (npm ciplus tests) passes.Related Issues
https://github.com/Expensify/Expensify/issues/695671
Linked E/App PR
https://github.com/Expensify/App/pull/0
N/A. This is a dev-only dependency, and the published package doesn't change.
Automated Tests
None added; the change only affects dev dependencies. The existing Jest suite (which uses
jest-environment-jsdom) covers the only consumer.Manual Tests
N/A, build only dependency.
I built the PR just fine locally.
Author Checklist
### Related Issuessection above### Linked E/App PRsection above, and verified this change against it (E/App CI passed and manual testing completed)TestssectiontoggleReportand notonIconClick)myBool && <MyComponent />.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)Avataris modified, I verified thatAvataris working as expected in all cases)mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari