Repository navigation
Bump ws to patched versions (GHSA-96hv-2xvq-fx4p) - #873
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
melvin-bot
Bot
requested review from
danieldoglas
and removed request for
a team
October 26, 2026 13:06
Contributor
|
recheck |
MariaHCD
approved these changes
Oct 27, 2026
Contributor
danieldoglas
approved these changes
Oct 27, 2026
Contributor
|
all yours to merge @MariaHCD |
Contributor
|
@MariaHCD looks like this was merged without a test passing. These checks had not passed on 50ec4e2 when it was merged:
Please add a note explaining why this was done and remove the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Details
Bumps transitive
wsinpackage-lock.jsonto fix GHSA-96hv-2xvq-fx4p (memory exhaustion DoS):6.2.3→6.2.6(react-native,@react-native/dev-middleware)7.5.10→7.5.13(metro,react-devtools-core)8.18.3→8.22.0(jsdomviajest-environment-jsdom)All within existing semver ranges; no
package.jsonchange.Usage: Onyx never imports
ws. It's a dev-only transitive dep: RN/Metro dev tooling websockets, andjsdomin Jest tests. Not shipped in the published package, so no E/App PR is needed.Change Log
8.x
closeTimeoutoption; handled upcoming Node.js core breaking change.PerMessageDeflateandSec-WebSocket-Extensions/Sec-WebSocket-Protocolheader utils.websocket.close()with aTypedArrayreason.maxBufferedChunksandmaxFragmentsoptions.maxBufferedChunks/maxFragmentsdefaults.client_max_window_bits.protocolsoption; invalidclose()args no longer set state toCLOSING.7.x
6.x
Related Issues
Dependabot alerts 69, 70, 71 (internal tracking issue)
Linked E/App PR
Automated Tests
None added; lockfile-only dev-dep bump. Existing Jest suite (runs on
jsdom→ws@8) covers it in CI.npm cipassed locally with the new lockfile and installed all fivewscopies at the patched versions.Manual Tests
Suggested:
npm ci→ succeeds.npm ls ws --all→ only6.2.6,7.5.13,8.22.0.npm testandnpm run build→ pass.Author Checklist
### Related Issuessection above### Linked E/App PRsection above, and verified this change against it (E/App CI passed and manual testing completed)TestssectiontoggleReportand notonIconClick)myBool && <MyComponent />.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)Avataris modified, I verified thatAvataris working as expected in all cases)mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari