Repository navigation
Bump browserslist to 4.29.4 to patch GHSA-73wf-gq98-2v4g - #872
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
rlinoz
approved these changes
Oct 26, 2026
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
MonilBhavsar
approved these changes
Oct 29, 2026
Contributor
|
@MonilBhavsar looks like this was merged without a test passing. These checks had not passed on c523693 when it was merged:
Please add a note explaining why this was done and remove the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Bumps
browserslist4.25.1 → 4.29.4 (lockfile only) to patch GHSA-73wf-gq98-2v4g (high). Its deps (caniuse-lite,electron-to-chromium,node-releases,update-browserslist-db) were bumped andbaseline-browser-mappingadded, as 4.29.4 requires.Usage: Dev-only transitive dep. Babel (
@babel/helper-compilation-targets) andcore-js-compat(viaeslint-plugin-unicorn) use it to resolve browser targets. Not part of the published package.Change Log
nullusage incover X in Yquery.supportsqueries.orparsing performance.including kaiosin baseline queries.>and>=queries.SyntaxErrorregression of 4.28.3.firefox >= esrquery.BROWSERSLIST_TRACE_WARNINGenv var.throwOnMissingwithextendsquery.baseline-browser-mappingversion requirement.--permissionsupport.Related Issues
https://github.com/Expensify/Expensify/issues/695667
Linked E/App PR
N/A: dev-only lockfile change; the published package is unchanged.
Automated Tests
None added; lockfile-only. Melvin ran
npm ci,lint,typecheck,buildandjestlocally: all pass, exceptSQLiteProviderTest, which can't load the nativebetter-sqlite3binary in the sandbox (unrelated).Manual Tests
npm ci, thennpm ls browserslist: shows only 4.29.4.npm audit: nobrowserslistadvisory.npm run lint,npm run typecheck,npm run build,npm test: all pass.Author Checklist
### Related Issuessection above### Linked E/App PRsection above, and verified this change against it (E/App CI passed and manual testing completed)TestssectiontoggleReportand notonIconClick)myBool && <MyComponent />.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)Avataris modified, I verified thatAvataris working as expected in all cases)mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari