Skip to content

Bump browserslist to 4.29.4 to patch GHSA-73wf-gq98-2v4g - #872

Merged
MonilBhavsar merged 1 commit into
mainfrom
claude-bumpBrowserslist
Oct 29, 2026
Merged

MonilBhavsar merged 1 commit into
mainfrom
claude-bumpBrowserslist

Conversation

@MelvinBot

@MelvinBot MelvinBot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Details

Bumps browserslist 4.25.1 → 4.29.4 (lockfile only) to patch GHSA-73wf-gq98-2v4g (high). Its deps (caniuse-lite, electron-to-chromium, node-releases, update-browserslist-db) were bumped and baseline-browser-mapping added, as 4.29.4 requires.

Usage: Dev-only transitive dep. Babel (@babel/helper-compilation-targets) and core-js-compat (via eslint-plugin-unicorn) use it to resolve browser targets. Not part of the published package.

Change Log
  • 4.29.4: Fixed joined version bounds in version ray/range queries; fixed whitespace processing.
  • 4.29.3: Updated Firefox ESR.
  • 4.29.2: Fixed ignoring null usage in cover X in Y query.
  • 4.29.1: Fixed config name loading protection on Windows; case-insensitive negation, percentage and supports queries.
  • 4.29.0: Added query continuations across lines and array entries.
  • 4.28.9: Improved or parsing performance.
  • 4.28.8: Fixed including kaios in baseline queries.
  • 4.28.7: Improved parsing performance; fixed unbounded memory growth; fixed prototype write issue (this advisory).
  • 4.28.6: Fixed Electron version queries.
  • 4.28.5: Fixed > and >= queries.
  • 4.28.4: Fixed SyntaxError regression of 4.28.3.
  • 4.28.3: Fixed baseline query case-insensitivity.
  • 4.28.2: Fixed prototype pollution.
  • 4.28.1: Removed Baseline warning.
  • 4.28.0: Added firefox >= esr query.
  • 4.27.0: Added BROWSERSLIST_TRACE_WARNING env var.
  • 4.26.3: Fixed throwOnMissing with extends query.
  • 4.26.2: Fixed baseline-browser-mapping version requirement.
  • 4.26.1: Updated Firefox ESR.
  • 4.26.0: Added Baseline queries.
  • 4.25.4: Fixed Windows support for custom stats.
  • 4.25.3: Fixed ReDoS.
  • 4.25.2: Fixed Node.js --permission support.

Related Issues

https://github.com/Expensify/Expensify/issues/695667

Linked E/App PR

N/A: dev-only lockfile change; the published package is unchanged.

Automated Tests

None added; lockfile-only. Melvin ran npm ci, lint, typecheck, build and jest locally: all pass, except SQLiteProviderTest, which can't load the native better-sqlite3 binary in the sandbox (unrelated).

Manual Tests

  1. npm ci, then npm ls browserslist: shows only 4.29.4.
  2. npm audit: no browserslist advisory.
  3. npm run lint, npm run typecheck, npm run build, npm test: all pass.

Author Checklist

  • I linked the correct issue in the ### Related Issues section above
  • I linked the corresponding Expensify/App PR in the ### Linked E/App PR section above, and verified this change against it (E/App CI passed and manual testing completed)
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android / native
    • Android / Chrome
    • iOS / native
    • iOS / Safari
    • MacOS / Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@MelvinBot
MelvinBot requested a review from a team as a code owner October 26, 2026 13:05
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-26T13:08:05.465134Z c523693 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@melvin-bot
melvin-bot Bot requested review from rlinoz and removed request for a team October 26, 2026 13:06
@MelvinBot

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@MonilBhavsar
MonilBhavsar merged commit 921f806 into main Oct 29, 2026
10 of 17 checks passed
@os-botify

os-botify Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

🚀 Published to npm in 3.0.141 🎉

@melvin-bot melvin-bot Bot added the Emergency label Oct 29, 2026
@melvin-bot

melvin-bot Bot commented Oct 29, 2026

Copy link
Copy Markdown

@MonilBhavsar looks like this was merged without a test passing. These checks had not passed on c523693 when it was merged:

Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants