Repository navigation
Bump simple-git to 4.0.2 to address Dependabot alerts - #871
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
All contributors have signed the CLA ✍️ ✅ |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 551576db24
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
The AI left a comment, let me know when it's ready and I will review it! |
|
Addressed |
|
@MelvinBot Complete the checklist in the PR description |
|
@luacmartins I think you need to approve it too or I won't be able to merge it |
|
Done |
Details
Fixes the open
simple-gitDependabot alerts (2 critical, 4 high; all fixed in>= 4.0.1) by adding an npmoverridesentry that forcessimple-gitfrom 3.28.0 to 4.0.2.Usage: dev-only, transitive, through
reassure→@callstack/reassure-cli. It callscheckIsRepo()andrevparse()to label perf runs with the current branch and commit. Nothing ships in the published package.Why use an override instead of bumping
reassure:[email protected]is the first release onsimple-git@^4. It was published 5 days ago, and.npmrcsetsmin-release-age=7.Known caveat: v4 removed the default export, so
[email protected]logsFailed to detect git branch/commit hashand labels runs(unknown). Perf tests still run and pass. CI doesn't read that metadata. Follow-up: bump to[email protected]and drop the override after 2026-10-28.Change Log
4.0.2
VISUALenv var to theallowUnsafeEditorset (security).4.0.1
4.0.0 (major)
simpleGitexport. Removesimple-git/promiseandgitP.--conf=).gitchild process.git.input(data)for one-shot stdin.rebase -x/--execunderallowUnsafeExec.3.36.0
3.34.0 – 3.35.2
child_process. Publishing and dependency-tree changes.3.33.0
pathspecwrappers forclone/mirrorpaths. Improvegit -cchecks in the unsafe plugin.3.29.0 – 3.32.3
blockUnsafeOperationsPluginbypass fixes, including case-insensitiveprotocol.allowand option-parsing bypasses.Full log: https://github.com/steveukx/git-js/blob/main/simple-git/CHANGELOG.md
Related Issues
https://github.com/Expensify/Expensify/issues/695664
Linked E/App PR
https://github.com/Expensify/App/pull/000
Automated Tests
None added; the change only affects dependencies. Existing
Reassure Performance TestsCI covers the only consumer.Manual Tests
npm cicompletes without errors.npm ls simple-gitshows[email protected].npm run perf-testpasses all suites and writes.reassure/current.perf. TheFailed to detect git branchwarning is expected (see Details).Reassure Performance Testscheck passes on this PR.Author Checklist
### Related Issuessection above### Linked E/App PRsection above, and verified this change against it (E/App CI passed and manual testing completed)TestssectiontoggleReportand notonIconClick)myBool && <MyComponent />.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)Avataris modified, I verified thatAvataris working as expected in all cases)mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari