Repository navigation
Bump linkify-it from 5.0.0 to 5.0.2 - #870
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
|
recheck |
Contributor
|
@grgia The list in the description needs to be completed! |
Contributor
|
@MelvinBot merge main |
grgia
approved these changes
Oct 26, 2026
grgia
left a comment
Contributor
There was a problem hiding this comment.
Dev-only, this comes in through the docs generator and isn't in what we publish. Pulled the branch, tests, lint, typecheck and the docs build all pass. No QA needed.
pecanoro
approved these changes
Oct 26, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Bumps
linkify-it5.0.0 → 5.0.2 (lockfile only) to fix GHSA-v245-v573-v5vm (mailto:quadratic DoS).Usage: Dev-only, transitive:
jsdoc-to-markdown→jsdoc→markdown-it→linkify-it. Used only bynpm run build:docs(buildDocs.ts) to generateAPI.md/API-INTERNAL.md. Not shipped in the published package.Change Log
5.0.2
mailto:links (restrict user name to 64 chars).5.0.1
gregexes instead of slice.Related Issues
$ https://github.com/Expensify/Expensify/issues/695668
Linked E/App PR
Expensify/App#104599
Automated Tests
None needed (dev dependency bump).
npm ciandnpm run typecheckpass locally.npm run build:docsfailed in my environment withThere are no input files to process, on bothmainand this branch, so I couldn't verify docs output here.Manual Tests
Steps I ran on the branch:
npm cion Node 24.npm ls linkify-itshows a single 5.0.2.npm run typecheck,npm run lint,npm testall pass.npm run build:docscompletes with no diff inAPI.mdorAPI-INTERNAL.md.mailto:input against 5.0.0 and 5.0.2: seconds before, milliseconds after.No QA, dev-only dependency.
Author Checklist
### Related Issuessection above### Linked E/App PRsection above, and verified this change against it (E/App CI passed and manual testing completed)TestssectiontoggleReportand notonIconClick)myBool && <MyComponent />.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)Avataris modified, I verified thatAvataris working as expected in all cases)mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari