Repository navigation
Fix - iOS/Android: Markdown is not formatted, parser worklet throws Property 'MAX_PARSABLE_LENGTH' doesn't exist - #822
Merged
Conversation
war-in
approved these changes
Oct 30, 2026
Contributor
Author
|
Ahh, this needs to wait for #820, because of Playwright fail |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Fixes
Property 'MAX_PARSABLE_LENGTH' doesn't exist, thrown by the parser worklet on iOS and Android whenmaxLengthis omitted (regression from #775).A worklet unpacks its captured variables in the function body, after default parameter values are evaluated, so
maxLength = MAX_PARSABLE_LENGTHcan't see the constant. The default now moves into the body (maxLength ?? MAX_PARSABLE_LENGTH).Related Issues
#821
Manual Tests
Run the example app on iOS and Android, and verify the Markdown is formatted with no
MAX_PARSABLE_LENGTHerror. No unit test, because Jest doesn't run the parser as a worklet.Screenshots
Linked PRs
None.