Skip to content

fix: prevent partial links in URLs and emails with oversized hostnames - #966

Merged
JS00001 merged 2 commits into
Expensify:mainfrom
Uzaifm127:fix/104791-prevent-partial-autolinks
Oct 29, 2026
Merged

fix: prevent partial links in URLs and emails with oversized hostnames#966
JS00001 merged 2 commits into
Expensify:mainfrom
Uzaifm127:fix/104791-prevent-partial-autolinks

Conversation

@Uzaifm127

@Uzaifm127 Uzaifm127 commented Oct 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Explanation of Change

This PR follows up on the hostname length validation in expensify-common #951. Testing the App upgrade found two cases where an oversized hostname was rejected, but other parts of the same input were still formatted as links.

When a hostname contained an earlier valid-looking domain, such as foo.com, ExpensiMark could link that shorter domain even though it was part of one oversized hostname. When an email address had an oversized domain, the URL check could lose sight of the @ and link the part before it as a website.

This change keeps the whole hostname plain when it exceeds either hostname length limit. It also checks URL matches against the original email text, so rejecting the domain does not turn the address into a web link or a mention. Separate valid URLs before or after these inputs still become links.

Fixed Issues

$ #102500
PROPOSAL:

Tests

Test 1: Oversized hostnames

  1. Open the App and open any chat.

  2. Paste the following URL into the composer and add a space:

    https://foo.com.aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa.net

  3. Verify that the entire URL stays plain. In particular, https://foo.com must not become a link on its own.

  4. Repeat with this long dotted URL and verify that it also stays completely plain:

    https://foo.com.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.a.net

  5. Paste https://foo.com separately and verify that this valid URL becomes a link.

  6. Send each message and verify that it keeps the same formatting.

Test 2: Email with an oversized domain

  1. Open any chat.

  2. Paste the following text into the composer and add a space:

    valid.net foo.bar@aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa.com valid.org

  3. Verify that valid.net and valid.org become links, while the entire email address stays plain.

  4. Send the message and verify that the same parts remain linked or plain.

  5. Send [email protected] separately and verify that a normal email address is still linked.

  • Verify that no errors appear in the JS console

Offline tests

Same as Test

QA Steps

Same as Test

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android-native.1.mp4
Android: mWeb Chrome
Android-mweb.mp4
iOS: Native
iOS-native.mp4
iOS: mWeb Safari
iOS-safari.mp4
MacOS: Chrome / Safari
macOS.mp4

@Uzaifm127
fix(expensimark): keep oversized hostnames plain and preserve email c…
fb426c6 
…ontext when linking

Reject the full hostname when a label or the complete hostname exceeds its length limit. Previously, an earlier valid-looking domain could still become a partial link.

Check URL matches against the original email text after masking an oversized domain. This keeps the email's local part from becoming a web link and the remainder from becoming a mention.
@Uzaifm127 Uzaifm127 mentioned this pull request Oct 29, 2026
Open
38 tasks done
@Uzaifm127 Uzaifm127 changed the title fix: prevent partial links in URLs and emails with oversized hostnames [WIP] fix: prevent partial links in URLs and emails with oversized hostnames Oct 29, 2026
@Uzaifm127 Uzaifm127 changed the title [WIP] fix: prevent partial links in URLs and emails with oversized hostnames fix: prevent partial links in URLs and emails with oversized hostnames Oct 29, 2026
@Uzaifm127
Uzaifm127 marked this pull request as ready for review October 29, 2026 12:08
@Uzaifm127
Uzaifm127 requested a review from a team as a code owner October 29, 2026 12:08
@melvin-bot
melvin-bot Bot requested review from AndrewGable and removed request for a team October 29, 2026 12:09
@Uzaifm127

Uzaifm127 commented Oct 29, 2026

Copy link
Copy Markdown
Contributor Author

@AndrewGable Sorry for the review ping, this PR will be reviewed by @linhvovan29546 and @JS00001

Thanks.

@linhvovan29546

linhvovan29546 commented Oct 29, 2026

Copy link
Copy Markdown

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 29, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-29T12:13:10.002509Z
We couldn’t complete this review. Comment @codex review to try again.		 fb426c6 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 29, 2026

Copy link
Copy Markdown

Codex Review: Something went wrong. Try again later by commenting “@codex review”.

An unknown error occurred
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@linhvovan29546

linhvovan29546 commented Oct 29, 2026 •
edited
Loading

Copy link
Copy Markdown

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp Simulator Screenshot - iPhone 17 Pro Max - 2026-10-29 at 20 33 39 Simulator Screenshot - iPhone 17 Pro Max - 2026-10-29 at 20 33 31 Simulator Screenshot - iPhone 17 Pro Max - 2026-10-29 at 20 33 23
iOS: mWeb Safari
MacOS: Chrome / Safari pr966-all-cases-sent

linhvovan29546
linhvovan29546 suggested changes Oct 29, 2026
View reviewed changes
Comment thread lib/ExpensiMark.ts Resolved
@Uzaifm127

Uzaifm127 commented Oct 29, 2026

Copy link
Copy Markdown
Contributor Author

@linhvovan29546

  1. Can you use codex review here in this PR? I can see that it failed here but can you try one more time?
  2. If it would still fail then can't we run codex review in the App's PR by telling codex to review the expensify-common upgrade as 223 rather than version 213? before merging this expensify-common PR. I mean can there be a way to run codex review in the App PR after this expensify-common PR changes before merging this PR?

I'm unsure about codex review because codex review can't run in the PRs from fork, its an issue in codex in openai which is still open.

@linhvovan29546

linhvovan29546 commented Oct 29, 2026

Copy link
Copy Markdown

The Codex review command is unavailable. It only works for Expensify/App when a PR is marked ready for review.

@Uzaifm127

Uzaifm127 commented Oct 29, 2026

Copy link
Copy Markdown
Contributor Author

@JS00001 Could you please review this PR? TY

@JS00001
JS00001 merged commit b1fc20e into Expensify:main Oct 29, 2026
8 of 10 checks passed
@os-botify

os-botify Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

🚀 Published to npm in 2.0.224 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JS00001 JS00001 JS00001 approved these changes
@AndrewGable AndrewGable Awaiting requested review from AndrewGable
+1 more reviewer
@linhvovan29546 linhvovan29546 linhvovan29546 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@Uzaifm127 Uzaifm127

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Uzaifm127 @linhvovan29546 @JS00001