Repository navigation
Allow clean empty Java discovery inventories - #124
Merged
Merged
Conversation
A Java-free workstation needs no remediation. Return success for clean empty discovery while preserving real errors and offering --require-java for provisioning that expects a JVM.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
francoisl
approved these changes
Oct 27, 2026
francoisl
left a comment
francoisl
left a comment
Contributor
There was a problem hiding this comment.
Ran the script and it works for me, though I do have multiple local Java installs, so I'm probably the wrong person to test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
An employee laptop may legitimately have no Java installed. Make a clean
--allscan with an empty inventory a successful no-op in both dry-run and apply modes, rather than forcing Toolkit to recognize an error string as success.--require-javafor VM/image provisioning that must fail when Java is unexpectedly absent.AI Tests
python3 -B -m unittest discover -s tests/python -v(32 tests), including empty discovery in both modes/formats, strict mode with/without Java, and actual discovery/inspection failures.git diff --check. Tests use isolated fixtures; no installed JVM blocklists were modified.Related Issues
For https://github.com/Expensify/Expensify/issues/694722
Manual Tests
Tested locally.
Linked PRs
https://github.com/Expensify/Expensify-ToolKit/pull/205 can remove its empty-inventory exception after adopting the merged script revision and updated checksum. Keep that consumer pinned to the current behavior until then. VM/image callers can opt into
--require-javawhen adopting the new revision.