Skip to content

Set JEKYLL_ENV for help deploys #90725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
puneetlath wants to merge 4 commits into from
Closed

Set JEKYLL_ENV for help deploys #90725

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f47429f
Set JEKYLL_ENV for help deploys
puneetlath May 14, 2026
e6dd757
Flip CONST.html to default to production URL
MelvinBot May 19, 2026
f8ee641
Merge remote-tracking branch 'origin/main' into puneet-help-build
puneetlath Jun 19, 2026
4691aa1
Merge branch 'puneet-help-build' of github.com:Expensify/App into pun…
puneetlath Jun 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/_includes/CONST.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{% if jekyll.environment == "production" %}
{% assign MAIN_SITE_URL = "https://new.expensify.com" %}
{% else %}
{% if jekyll.environment == "development" %}
{% assign MAIN_SITE_URL = "https://dev.new.expensify.com:8082" %}
Comment on lines +1 to 2

@chatgpt-codex-connector chatgpt-codex-connector Bot Jun 15, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Set JEKYLL_ENV where the deploy build runs

In the inspected deployExpensifyHelp workflow, the production push build at .github/workflows/deployExpensifyHelp.yml:70-72 still runs bundle exec jekyll build without exporting JEKYLL_ENV; with Jekyll's default unset environment being development, this branch still assigns MAIN_SITE_URL to https://dev.new.expensify.com:8082 for deployed help builds. As a result, the generated production help pages continue to send users to the dev Concierge URL instead of https://new.expensify.com/concierge unless the workflow is also changed to set JEKYLL_ENV=production.

Useful? React with 👍 / 👎.

{% else %}
{% assign MAIN_SITE_URL = "https://new.expensify.com" %}
{% endif %}

{% capture CONCIERGE_CHAT_URL %}{{MAIN_SITE_URL}}/concierge{% endcapture %}
Loading