Repository navigation
[No QA] Merge main - #87931
[No QA] Merge main #87931
Conversation
…serChat Fix chat from new user not becoming un-bold when read offline
…tion Remove REIMBURSED from the deprecatedOldReportActions list
Made-with: Cursor
Part 4: Remove Onyx.connect() for the key: ONYXKEYS.SESSION in src/libs/actions/Policy/Policy.ts
…ecks deleted transaction thread
Signed-off-by: krishna2323 <[email protected]>
Signed-off-by: krishna2323 <[email protected]>
Signed-off-by: krishna2323 <[email protected]>
…to perf-send-message-phase-2-1
…to perf-send-message-phase-2-4
…x-flag-comment-page-in-thread
…de-to-keep-navigation-handling-in-the-UI-components
…de-to-keep-navigation-handling-in-the-UI-components # Conflicts: # src/pages/iou/request/step/IOURequestStepConfirmation.tsx
…Reader-Many-Pages-There-is-no-dialog-role-and-title-announced
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| 1. Click **Connect Bank Account**. | ||
| 2. Select either **Connect online with Plaid (preferred)** or **Connect manually**. | ||
| 3. Enter your bank details. | ||
| 1. In the navigation tabs (on the left on web, on the bottom on mobile)**,** click **Workspace > [Workspace name]**. |
There was a problem hiding this comment.
Naming convention inconsistency: This line uses **Workspace > [Workspace name]** but other articles in this PR consistently use **Workspaces > [Workspace Name]** (plural "Workspaces" and capitalized "Name"). Use the consistent format matching the UI tabs.
| 3. Click **Enable Workflows**. | ||
| 4. A **Workflows** setting will appear in the left-hand menu. | ||
| 5. Click **Workflows** and enable **Make or Track Payments**. | ||
| To connect a business bank account, the Workspace must have Workflows enabled. [Learn how to enable Workflows](/articles/new-expensify/workspaces/Workspace-Workflows#enable-workflows). |
There was a problem hiding this comment.
Cross-linking violation: The link on this line uses an anchor fragment #enable-workflows targeting a specific section. While the relative link format is correct, verify that this anchor actually exists in the target article. Additionally, the link appears inside an explanatory paragraph (not numbered steps), so placement is acceptable.
| --- | ||
|
|
||
| ## Step 7: Watch for the test transaction message | ||
| ## What to expect after submitting your bank account details |
There was a problem hiding this comment.
Heading rule violation: ## What to expect after submitting your bank account details -- while "What" is a question word, this reads as a topic label. Consider rephrasing to be more direct:
| ## What to expect after submitting your bank account details | |
| ## What happens after you submit your bank account details |
This aligns with the pattern used elsewhere in this PR (e.g., "What happens after you assign company cards").
| --- | ||
|
|
||
| ## Step 8: Validate the test transactions | ||
| ## How business bank accounts appear in Wallet |
There was a problem hiding this comment.
Heading rule violation: ## How business bank accounts appear in Wallet -- this is a descriptive label rather than a task or question. Consider:
| ## How business bank accounts appear in Wallet | |
| ## How to view business bank accounts in Wallet |
| --- | ||
|
|
||
| # Why is the business bank account locked? | ||
| ## Why your business bank account is locked |
There was a problem hiding this comment.
Heading rule violation: ## Why your business bank account is locked does not describe an action the user takes or a question the user has. Consider rephrasing as a question:
| ## Why your business bank account is locked | |
| ## Why is your business bank account locked? |
| **Note:** Any payments already in progress before the bank account was unshared will still complete. | ||
|
|
||
| **Note:** Admins with access can unshare the business bank account from anyone else — even the person who originally added it. | ||
| -- |
There was a problem hiding this comment.
Markdown formatting issue: Line 43 has -- instead of --- for a horizontal rule separator. This will render as an em-dash rather than a horizontal rule.
| -- | |
| --- |
| --- | ||
|
|
||
| ## Unsharing when the account is set as Expensify Card settlement account | ||
| ## What to do if you can’t unshare a business bank account |
There was a problem hiding this comment.
Heading rule violation: ## What to do if you can't unshare a business bank account -- while functional, this could be more direct. Consider:
| ## What to do if you can’t unshare a business bank account | |
| ## How to resolve issues when you can't unshare a business bank account |
|
|
||
| # How to Validate Your Bank Account | ||
| ## When can a business bank account be validated | ||
|
|
There was a problem hiding this comment.
Heading rule violation: ## When can a business bank account be validated -- this heading is informational rather than task-based. It does start with "When" (a question word), but would read better as a proper question with a question mark:
| ## When can a business bank account be validated? |
| --- | ||
|
|
||
| # FAQ | ||
| ## What to do if test transactions don't arrive |
There was a problem hiding this comment.
Heading rule violation: ## What to do if test transactions don't arrive -- while functional, consider using a more task-based phrasing for consistency with other headings:
| ## What to do if test transactions don't arrive | |
| ## How to resolve missing test transactions |
|
|
||
| --- | ||
|
|
||
| # How to view attendees on a report |
There was a problem hiding this comment.
Structure violation: # How to view attendees on a report is a second # heading in this article. Per HELP_AUTHORING_GUIDELINES.md Section 4, articles must have exactly one # heading (the article title), with no other # headings allowed except # FAQ. This should be demoted to ##:
| # How to view attendees on a report | |
| ## How to view attendees on a report |
| Once a Distance expense is created, it can be submitted on a report. To learn how to add expenses to a report, see [Create and Submit Reports](https://help.expensify.com/articles/new-expensify/reports-and-expenses/Create-and-Submit-Reports). | ||
| --- | ||
|
|
||
| ## How to create a Distance expense using Odometer readings (Web and Mobile) |
There was a problem hiding this comment.
AI readiness / heading improvement: ## How to create a Distance expense using Odometer readings (Web and Mobile) -- "Odometer" is capitalized mid-sentence. Unless the UI specifically capitalizes "Odometer" as a proper label, use lowercase for consistency:
| ## How to create a Distance expense using Odometer readings (Web and Mobile) | |
| ## How to create a Distance expense using odometer readings (Web and Mobile) |
| No. GPS tracking requires the iOS or Android mobile app because it uses your device's location services. On web or desktop, you'll see a prompt to download the mobile app when selecting GPS. You can still use map-based or manual distance entry on any platform. | ||
|
|
||
| ## Can my odometer images be SmartScanned? | ||
|
|
There was a problem hiding this comment.
Readability: Consider adding a brief note that SmartScan works for receipt text but not odometer dial images, to set expectations more clearly for the user.
| --- | ||
|
|
||
| # Available filters for grouping and currency conversion | ||
| ## How to use grouping, chart views, and currency conversion filters |
There was a problem hiding this comment.
Heading rule violation: ## How to use grouping, chart views, and currency conversion filters covers multiple topics in a single heading. Per HELP_AUTHORING_GUIDELINES.md Section 1, articles should solve one primary workflow. This heading could be split for better scannability, or kept as-is since they are closely related. However, a more concise heading would improve readability.
|
|
||
| --- | ||
|
|
||
| # How to freeze or unfreeze your Expensify Card |
There was a problem hiding this comment.
Structure violation: # How to freeze or unfreeze your Expensify Card is an additional # heading beyond the article title. Per HELP_AUTHORING_GUIDELINES.md Section 4, only one # heading (the article title) and an optional # FAQ are allowed. Demote this to ##:
| # How to freeze or unfreeze your Expensify Card | |
| ## How to freeze or unfreeze your Expensify Card |
|
|
||
| --- | ||
|
|
||
| # How to freeze or unfreeze an Expensify Card |
There was a problem hiding this comment.
Structure violation: # How to freeze or unfreeze an Expensify Card is an additional # heading beyond the article title. Per HELP_AUTHORING_GUIDELINES.md Section 4, only one # heading (the article title) and an optional # FAQ are allowed. Demote to ##:
| # How to freeze or unfreeze an Expensify Card | |
| ## How to freeze or unfreeze an Expensify Card |
| --- | ||
|
|
||
| # Why Add Another Contact Method? | ||
| ## Why add another contact method to your Expensify account |
There was a problem hiding this comment.
Heading rule violation: ## Why add another contact method to your Expensify account is missing a question mark, and it reads as a sentence fragment rather than a complete question. Consider rephrasing:
| ## Why add another contact method to your Expensify account | |
| ## Why should you add another contact method to your Expensify account? |
| --- | ||
|
|
||
| # Important Notes | ||
| ## How login works with multiple contact methods |
There was a problem hiding this comment.
Heading rule violation: ## How login works with multiple contact methods describes system behavior rather than a user task or question. Consider rephrasing to be more user-focused:
| ## How login works with multiple contact methods | |
| ## How to log in with multiple contact methods |
|
|
||
| ## How can I confirm my current default contact method? | ||
|
|
||
| You can view your current default contact method by navigating to **Account > Profile** and clicking **Contact methods**. Your default contact method will show a note that says "_We'll use this method to contact you_". |
There was a problem hiding this comment.
Prohibited navigation language: The phrase "by navigating to" uses vague navigation phrasing prohibited by HELPSITE_NAMING_CONVENTIONS.md. Use the established pattern instead:
| You can view your current default contact method by navigating to **Account > Profile** and clicking **Contact methods**. Your default contact method will show a note that says "_We'll use this method to contact you_". | |
| You can view your current default contact method in the navigation tabs by selecting **Account > Profile** and clicking **Contact methods**. Your default contact method will show a note that says "_We'll use this method to contact you_". |
| - Many tax authorities do not require reporting tax amounts by rate; therefore, you can apply the highest rate on the receipt and then modify the tax amount on the receipt if necessary. Please check with your tax advisor to determine if this approach suits you. | ||
| - Alternatively, you can apply each specific tax rate by splitting the expense by the applicable costs for each rate. To do this, open the expense and click **Split Expense**. Then, apply the correct tax rate to each. | ||
|
|
||
| ## What happens if an expense with tax is moved to a workspace where tax tracking is disabled? |
There was a problem hiding this comment.
Readability: Good FAQ question that addresses a real user scenario. However, the answer mixes UI instructions ("tap the Tax or Tax amount field") with explanatory content. Consider separating the explanation from the action steps for better scannability.
| Once your card is connected, it will appear under **Assigned cards** in the **Wallet**, and transactions will begin importing automatically. | ||
|
|
||
| --- | ||
|
|
There was a problem hiding this comment.
Heading rule violation: ## What to do if you see a company card warning -- "What to do" is a task-adjacent phrase but does not start with a standard action verb or question word pattern. Consider rephrasing to be more direct:
| ## How to resolve a company card warning when adding a personal card |
|
|
||
| --- | ||
|
|
||
| ## What happens when you reach the free card limit |
There was a problem hiding this comment.
Heading rule violation: ## What happens when you reach the free card limit -- this reads as a topic label describing system behavior. Consider rephrasing as a question for better searchability:
| ## What happens when you reach the free card limit | |
| ## What happens when you reach the free personal card limit? |
|
|
||
| ## How can I check if my bank or card issuer is supported? | ||
|
|
||
| Expensify supports most major banks and card issuers worldwide. [Learn how to check which banks are supported in Expensify](/articles/new-expensify/connect-credit-cards/Check-Supported-Banks) |
There was a problem hiding this comment.
Missing period at end of sentence: The sentence after the link is missing a period:
| Expensify supports most major banks and card issuers worldwide. [Learn how to check which banks are supported in Expensify](/articles/new-expensify/connect-credit-cards/Check-Supported-Banks) | |
| Expensify supports most major banks and card issuers worldwide. [Learn how to check which banks are supported in Expensify](/articles/new-expensify/connect-credit-cards/Check-Supported-Banks). |
| 5. Choose your **Commercial feed** and select **Next**. | ||
| 6. Choose your bank from the list and follow the instructions. | ||
|
|
||
| ## How to enable a Mastercard commercial card feed (CDF) |
There was a problem hiding this comment.
Multiple workflows concern: This article covers setting up commercial card feeds generically (lines 29-38), plus three separate vendor-specific workflows (Mastercard CDF, Visa VCF, Amex GL1025). Per HELP_AUTHORING_GUIDELINES.md Section 1, each article should solve one primary workflow. Consider whether the vendor-specific instructions should be separate articles, or if the current structure is acceptable since they all fall under "commercial card feed setup."
| - **Page 2:** Leave blank. | ||
| - **Page 3:** Re-enter client name and Control Account. | ||
| - **Page 4:** Add country, authorization name, title, and signature (DD/MM/YY format). | ||
| 3. Email the completed forms to: **[email protected]** |
There was a problem hiding this comment.
Formatting: The email address on this line ([email protected]) should be formatted as a link or bolded for visibility, so users can easily identify and copy it:
| 3. Email the completed forms to: **[email protected]** | |
| 3. Email the completed forms to: **[email protected]** |
|
|
||
| If you see an error while reconnecting, use the guidance below: | ||
|
|
||
| **Error: Too many attempts** |
There was a problem hiding this comment.
Readability / structure: The error troubleshooting section (lines 38-60) uses bold **Error:** labels inline rather than as structured list items or a table. While functional, this section would be more scannable as a table with columns for Error, Cause, and Resolution. This is a suggestion for improvement, not a strict governance violation.
|
|
||
| ## How to assign company cards | ||
|
|
||
| 1. Click the navigation tabs (on the left on web, on the bottom on mobile) and select **Workspaces > [Workspace Name]**. |
There was a problem hiding this comment.
Navigation instruction inconsistency: This line uses Click the navigation tabs ... and select **Workspaces > [Workspace Name]**. The word "select" is used here, but across the other new articles in this PR, the pattern varies between "select", "go to", and "click". For consistency, pick one pattern and apply it everywhere. Most articles in this PR use "select" here, which is fine -- just verify it's consistent with the actual UI interaction.
| title: How to use search operators in Expensify | ||
| description: Learn how to use advanced search filters, comparisons, and groupings to find exactly what you need across expenses, chats, reports, and more. | ||
| keywords: [New Expensify, search operators, filters, search rules, expense search, report search, chat filters, advanced search, group-by, view, chart, search syntax] | ||
| internalScope: Audience is all Expensify users. Covers search operator syntax for filtering, grouping, and chart views. Does not cover saved search management or Search page UI navigation. |
There was a problem hiding this comment.
Terminology violation: Use "members" instead of "users" per Expensify naming conventions. "User" should be "member" throughout HelpDot articles.
| internalScope: Audience is all Expensify users. Covers search operator syntax for filtering, grouping, and chart views. Does not cover saved search management or Search page UI navigation. | |
| internalScope: Audience is all Expensify members. Covers search operator syntax for filtering, grouping, and chart views. Does not cover saved search management or Search page UI navigation. |
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.3.61-0 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.3.61-4 🚀
|
20 participants
Explanation of Change
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari