Repository navigation
[No QA] Docs updates for E/A#104074 Use this-year in Spend over time search example - #105669
Conversation
Co-authored-by: Krishna Chaitanya <[email protected]>
|
A preview of your ExpensifyHelp changes have been deployed to https://f2e481d8.helpdot.pages.dev ⚡️ Updated articles: |
|
@MelvinBot mark this PR as ready for review |
|
🤖 Done. This PR is now marked as ready for review. |
Product reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR? |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
HelpDot Documentation Review Overall Assessment Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: No inline comments were necessary given the minimal, compliant scope of this change. |
joekaufmanexpensify
left a comment
There was a problem hiding this comment.
good for product
Explanation of Change
Updates the help site for Deprecate Year to date in favor of This year.
That PR removed Year to date from the date picker and replaced it with This year. Searches that still use
date:year-to-dateare now rewritten todate:this-yearand cover the whole year.Article updated: Use Search Operators to Filter and Analyze
Sentence that was incorrect (in the "How to build reports using search operators" examples):
What changed: The example now uses
date:this-year, the value that replaced the deprecatedyear-to-datepreset.@c3024, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.Fixed Issues
$ #104074
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari