[CP Staging] Fix: bring chart spinner back in the same render on reload by sharabai · Pull Request #105163 · Expensify/App

sharabai · 2026-10-27T17:10:13Z

Explanation of Change

A regression from #103210. When a chart that is already shown starts loading again without remounting, as when the Insights card switches from Top spenders to Top categories (both bar charts), the bar body renders nothing at once, but ChartReveal only learns about it from the chart's layout effect a commit later. For that commit the card is empty, and on Android Home's scroll view clamps to the shorter page. ChartFrame now passes its isLoading to ChartReveal, which counts it as loading, so the spinner comes back at full height in the same render.

The jump only shows on an insight's first load after a sign-in or a cache clear, since an insight that is already cached renders without going back to loading.

Fixed Issues

$ #105108
PROPOSAL: N/A

Tests

Preconditions:

An admin of a workspace with a few months of expenses across several categories.
The account is not on the insightsPage beta.

1. Home stays on the Insights card when it switches insight (Android: Native, exercises the fix)

Sign in fresh, or go to Account > Troubleshoot > Clear cache and restart.
Open Home and verify that the Insights card shows Spend over time.
Scroll Home to the bottom.
Open the card's title dropdown and pick Top spenders. Verify that a spinner shows, then the chart fades in.
Open the dropdown again and pick Top categories.
Verify that the page stays on the Insights card, with the spinner holding the card's height until Top categories fades in.
To run it again, start over from step 1, since each run needs a fresh cache.

2. Chart loading on web (MacOS: Chrome, regression)

As in test 1 steps 1 to 5, in Chrome.
Verify that each pick shows the spinner at the card's height, then the chart fades in without the card changing height.

Verify that no errors appear in the JS console

Offline tests

N/A: the change only affects how the chart card draws a load it already knows about, and offline adds no path to it.

QA Steps

Same as tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2026-10-27.at.18.07.54.mov

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

melvin-bot · 2026-10-27T17:14:10Z

@daledah Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector · 2026-10-27T17:14:15Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-27T17:28:33.904795Z	`daadf30`	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

sharabai · 2026-10-27T17:15:23Z

@luacmartins @daledah this fixes the deploy blocker #105108 caused by #103210. It is a 1 line change in ChartFrame plus a small one in ChartReveal, with a unit test. Could you review it quickly so it can be merged and CP'd to staging? Thanks!

daledah · 2026-10-27T17:18:15Z

Thanks @sharabai for the PR, i'll review it in a couple of hours

luacmartins

LGTM

daledah · 2026-10-27T17:49:26Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If the PR adds or modifies the UI:
- I asked an AI agent to review the changes for accessibility issues and addressed its findings.
- I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
- I verified all new/changed elements have meaningful accessible names and roles.
- I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-10-28.at.00.46.21.mov

MacOS: Chrome / Safari

Screen.Recording.2026-10-28.at.00.48.59.mov

daledah

LGTM

daledah · 2026-10-27T17:50:14Z

@luacmartins all yours

…ghts-scroll-jump [CP Staging] Fix: bring chart spinner back in the same render on reload (cherry picked from commit 0b8e418) (cherry-picked to staging by jasperhuangg)

OSBotify · 2026-10-27T18:28:39Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-10-27T18:36:21Z

🚧 luacmartins has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-10-27T18:59:31Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #105163 with the pinned Mobile-Expensify submodule.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-0b8e4182-cd0c1f9-16686b4d083c14c59350dec9e1c6d15fa7b8424f/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-0b8e4182-cd0c1f9-1406c0069963e968e3940d80599dd2c68e696b9b/index.html

Web 🕸️
https://105163.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

os-botify · 2026-10-27T19:09:31Z

🔁 Filed a Staging retest request for deploy blockers #105108 after this PR was cherry-picked to staging.

OSBotify · 2026-10-27T19:11:42Z

🚀 Cherry-picked to staging by https://github.com/jasperhuangg in version: 9.5.23-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-10-27T19:16:12Z

No help site update needed. This PR fixes a loading glitch where the Insights card briefly emptied and the Home page jumped when switching charts, which is an implementation detail that no article describes.

view run

OSBotify · 2026-10-27T22:09:23Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.5.23-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

OSBotify · 2026-10-27T22:12:26Z

🚀 Cherry-picked to staging by https://github.com/jasperhuangg in version: 9.5.24-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

MelvinBot · 2026-10-27T22:14:38Z

No help site update needed. This PR only changes how the Insights chart card shows its loading spinner when you switch charts, which is loading behavior that no article describes.

view run

OSBotify · 2026-10-29T00:59:59Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.5.24-8 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

Bring chart spinner back in the same render on reload

daadf30

melvin-bot Bot assigned sharabai Oct 27, 2026

sharabai mentioned this pull request Oct 27, 2026

[Due for payment 2026-11-03] Android-Home-Pick Top categories in Insight card page scroll up over that card #105108

Closed

1 of 7 tasks

sharabai changed the title ~~Bring chart spinner back in the same render on reload~~ Fix: bring chart spinner back in the same render on reload Oct 27, 2026

sharabai marked this pull request as ready for review October 27, 2026 17:14

sharabai requested review from a team as code owners October 27, 2026 17:14

melvin-bot Bot requested review from daledah and removed request for a team October 27, 2026 17:14

melvin-bot Bot requested review from garrettmknight and removed request for a team October 27, 2026 17:14

luacmartins approved these changes Oct 27, 2026

View reviewed changes

luacmartins changed the title ~~Fix: bring chart spinner back in the same render on reload~~ [CP Staging] Fix: bring chart spinner back in the same render on reload Oct 27, 2026

daledah approved these changes Oct 27, 2026

View reviewed changes

melvin-bot Bot requested a review from luacmartins October 27, 2026 17:49

luacmartins approved these changes Oct 27, 2026

View reviewed changes

luacmartins merged commit 0b8e418 into Expensify:main Oct 27, 2026
51 of 54 checks passed

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Oct 27, 2026

OSBotify mentioned this pull request Oct 27, 2026

Deploy Checklist: New Expensify 2026-10-26 #105056

Closed

84 tasks done

Conversation

sharabai commented Oct 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Oct 27, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

sharabai commented Oct 27, 2026

Uh oh!

daledah commented Oct 27, 2026

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

daledah commented Oct 27, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

daledah left a comment

Choose a reason for hiding this comment

Uh oh!

daledah commented Oct 27, 2026

Uh oh!

Uh oh!

OSBotify commented Oct 27, 2026

Uh oh!

github-actions Bot commented Oct 27, 2026

Uh oh!

github-actions Bot commented Oct 27, 2026

Uh oh!

os-botify Bot commented Oct 27, 2026

Uh oh!

OSBotify commented Oct 27, 2026

Uh oh!

MelvinBot commented Oct 27, 2026

Uh oh!

OSBotify commented Oct 27, 2026

Uh oh!

OSBotify commented Oct 27, 2026

Uh oh!

MelvinBot commented Oct 27, 2026

Uh oh!

OSBotify commented Oct 29, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

sharabai commented Oct 27, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Oct 27, 2026 •

edited

Loading