[Gonals]

Explanation of Change

Testing-only companion PR for the react-native-onyx PR Bump transitive lodash to 4.18.1. The Onyx PR checklist requires every Onyx PR to link an E/App PR. Not for merge: close this PR once the Onyx PR merges.

This pins react-native-onyx via git+https to 755741eb on the Onyx branch alberto-onyxLodash880. That commit is the 3.0.119 release App uses, plus a cherry-pick of the Onyx PR's only change: lodash 4.17.21 → 4.18.1 in Onyx's own package-lock.json. The Onyx PR branch itself is based on 3.0.123, which declares react-native-nitro-sqlite@^10.2.0 as a peer dependency. App is on 9.8.3, so pinning that branch's HEAD fails npm install with ERESOLVE.

lodash is only a dev dependency of Onyx, so the built package is unchanged. npm pack of the pinned commit, including its prepare build, produces integrity sha512-1idaVW/nP0jTSjjevAzzMlk6gOLqkmT6gJaDYI0fWx21vtQLJ0gZeMEJb16g08Bd9nY4bsALWb4bkzhmiLWIfw==, identical to the published 3.0.119 tarball. That's why only resolved changes for react-native-onyx in package-lock.json.

Fixed Issues

For https://github.com/Expensify/Expensify/issues/695675
PROPOSAL:

Tests

1. Run npm pack git+https://github.com/Expensify/react-native-onyx.git#755741ebfde1dc1f573eabb17bec06a34f6fd86f --dry-run --json.
2. Verify the reported integrity is sha512-1idaVW/nP0jTSjjevAzzMlk6gOLqkmT6gJaDYI0fWx21vtQLJ0gZeMEJb16g08Bd9nY4bsALWb4bkzhmiLWIfw==, the same as the [email protected] tarball on npm.
3. Verify the E/App CI checks on this PR pass.

• Verify that no errors appear in the JS console

Offline tests

None. The installed Onyx package is byte-identical to 3.0.119, so offline behavior doesn't change.

QA Steps

None. This PR is for E/App CI verification only and won't be merged.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If the PR adds or modifies the UI:
  • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
  • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
  • I verified all new/changed elements have meaningful accessible names and roles.
  • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari