Skip to content

fix: validate scan-route IOU types and remove unsafe assertions - #104926

Draft
KJ21-ENG wants to merge 1 commit into
Expensify:mainfrom
KJ21-ENG:seatbelt-v2/batch-20261023-804bc132-run-4-8fdce73b
Draft

KJ21-ENG wants to merge 1 commit into
Expensify:mainfrom
KJ21-ENG:seatbelt-v2/batch-20261023-804bc132-run-4-8fdce73b

Conversation

@KJ21-ENG

@KJ21-ENG KJ21-ENG commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Remove unsafe assertions using existing card-feed types, a derived report-route view, action discrimination, and optional workspace-chat values. Correct useScanRouteParams to return only iouType and routeName: all nine supported IOU types remain distinct, absent or unsupported types become undefined, and unconsumed params are no longer spread into the result.

Changed files:

  • src/pages/home/TimeSensitiveSection/items/FixCompanyCardConnection.tsx
  • src/pages/inbox/ReportHeader.tsx
  • src/pages/inbox/report/actionContents/ActionContentRouter.tsx
  • src/pages/inbox/sidebar/FABPopoverContent/useScanActions.ts
  • src/pages/iou/request/step/IOURequestStepScan/hooks/useScanRouteParams.ts
  • tests/unit/hooks/useScanRouteParamsTest.tsx

Fixed Issues

$ #94739
PROPOSAL: #94739 (comment)

Tests

Focused lint, formatting, spelling, React Compiler checks, and the selected Jest suites passed; focused TypeScript reported no changed-root diagnostics. CI passed typecheck, lint, format, React Compiler, and the selected Jest suites.

Manual QA required. QA before review is recommended for real mobile scan navigation and receipt handoff.

Run each case on Android native, Android mWeb Chrome, iOS native, and iOS mWeb Safari. Use a local candidate build against the supported test backend, a narrow mobile layout, and an unrestricted signed-in account that can create expenses and split expenses in a group chat. Create or select recipients, a workspace, and a group chat through normal App UI. Have two distinguishable ordinary receipts ready and grant camera access when prompted. Check for unexpected JS console errors during each case.

1. Create expense with two scanned receipts

Setup: Start in Inbox on a narrow mobile layout with the shared expense-capable account.

  1. Long-press the plus button. Scan opens with a multi-scan control.
  2. Enable multi-scan. The control shows the enabled state, or the normal introductory explanation appears.
  3. Dismiss the introductory explanation if shown. The camera is usable with multi-scan enabled.
  4. Capture the first receipt. One receipt appears in the preview ribbon and scanning remains available.
  5. Capture the second distinct receipt. The ribbon contains both receipts.
  6. Submit the preview ribbon. Both receipts remain represented in the resulting participant or expense-confirmation flow.

2. Split an expense with one scanned receipt

Setup: Open an ordinary group chat where the account is offered Split expense in the plus menu.

  1. Choose Split expense from the chat plus menu. The split-expense creation flow opens.
  2. Select Scan. The camera opens without a multi-scan control.
  3. Capture one receipt. The app navigates directly to the split participant or confirmation flow with the captured receipt retained.

3. Add a receipt from manual confirmation

Setup: Use Create expense > Manual, enter an amount, and choose a recipient or workspace as needed to reach confirmation without a receipt. Note the amount and selection.

  1. Press Upload receipt on the receipt-free manual confirmation. The scan camera opens without a multi-scan control.
  2. Capture one receipt. The app navigates directly to expense confirmation or ordinary participant selection with that receipt retained. If confirmation opens, it shows the original amount and selected recipient or workspace.
  3. If participant selection appears, choose the same recipient or workspace used in setup. Confirmation shows the receipt and the original amount and selected recipient/workspace.
  • Verify that no errors appear in the JS console

Offline tests

N/A: route-field projection and validation do not change request queues, persistence, receipt storage, network recovery, or card-feed reconnect behavior, so no additional offline case is selected.

QA Steps

Same as tests, after the candidate is deployed to staging and equivalent expense, group-chat, and camera access is available.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Execution evidence and coverage limits

No recordings were supplied. Execution of the three cases across all four mobile lanes and console cleanliness remain unverified. The automated suites mock navigation or the scan hook and do not establish real mobile navigation, camera capture, or receipt handoff. No distinct offline case applies; offline testing remains unverified.

Seatbelt-Operation: 5b331e45-ea5c-4a83-a77d-96fbaf6c8f98
@KJ21-ENG KJ21-ENG changed the title Clarify type contracts for card feeds, report navigation, and receipt scanning fix: validate scan-route IOU types and remove unsafe assertions Oct 24, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant