Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/libs/API/parameters/AddPersonalBankAccountParams.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ type AddPersonalBankAccountParams = {
legalFirstName?: string;
legalLastName?: string;
addressStreet?: string;
addressStreet2?: string;
addressCity?: string;
addressState?: string;
addressZip?: string;
Expand Down
3 changes: 2 additions & 1 deletion src/libs/actions/BankAccounts.ts
Original file line number Diff line number Diff line change
Expand Up @@ -561,7 +561,8 @@ function addPersonalBankAccount(
phoneNumber: account?.phoneNumber,
legalFirstName: account?.legalFirstName,
legalLastName: account?.legalLastName,
addressStreet: getFormattedStreet(account?.addressStreet, account?.addressStreet2),
addressStreet: account?.addressStreet,
addressStreet2: account?.addressStreet2 ?? '',
addressCity: account?.addressCity,
addressState: account?.addressState,
addressZip: account?.addressZipCode,
Expand Down
26 changes: 26 additions & 0 deletions tests/unit/BankAccountsTest.ts
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,32 @@ describe('BankAccounts', () => {
const personalBankAccount = await getOnyxValue(ONYXKEYS.PERSONAL_BANK_ACCOUNT);
expect(getLatestErrorMessage(personalBankAccount)).toBe(serverMessage);
});

test('sends both address lines as separate params', () => {
// Given an account with a second address line, which the API rejects when joined into addressStreet with a newline
const account = {addressStreet: '123 Main St', addressStreet2: 'Apt 4B'};

// When adding the personal bank account
addPersonalBankAccount(account, undefined);

// Then each line is sent in its own param so the backend can store both
expect(mockWrite).toHaveBeenCalledWith(
WRITE_COMMANDS.ADD_PERSONAL_BANK_ACCOUNT,
expect.objectContaining({addressStreet: '123 Main St', addressStreet2: 'Apt 4B'}),
expect.anything(),
);
});

test('sends an empty second address line when addressStreet2 is missing', () => {
// Given an account without a second address line
const account = {addressStreet: '123 Main St'};

// When adding the personal bank account
addPersonalBankAccount(account, undefined);

// Then the second line is sent as an empty string, matching updatePersonalBankAccountInfo
expect(mockWrite).toHaveBeenCalledWith(WRITE_COMMANDS.ADD_PERSONAL_BANK_ACCOUNT, expect.objectContaining({addressStreet: '123 Main St', addressStreet2: ''}), expect.anything());
});
});

describe('deletePaymentBankAccount', () => {
Expand Down
Loading