Skip to content

[No QA] Block compromised Java certificates in CI #104803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
francoisl merged 2 commits into from
Oct 23, 2026
Merged

[No QA] Block compromised Java certificates in CI #104803

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c572f87
ci: block compromised Java certificates
roryabraham Oct 22, 2026
8dc91b0
ci: reuse shared Gradle JDK restrictions
roryabraham Oct 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/buildAndroid.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,11 @@ jobs:
- name: Setup Gradle
uses: gradle/actions/setup-gradle@50e97c2cd7a37755bbfafc9c5b7cafaece252f6e

- name: Block compromised Java certificates
uses: Expensify/GitHub-Actions/block-compromised-java-certificates@b70c378d6cfae84f6844379eef3568cb33ea9680
with:
restrict-gradle: 'true'

- name: Setup 1Password CLI and certificates
uses: Expensify/GitHub-Actions/setup-certificate-1p@main
with:
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/publishReactNativeAndroidArtifacts.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,11 @@ jobs:
- name: Setup Gradle
uses: gradle/actions/setup-gradle@50e97c2cd7a37755bbfafc9c5b7cafaece252f6e

- name: Block compromised Java certificates
uses: Expensify/GitHub-Actions/block-compromised-java-certificates@b70c378d6cfae84f6844379eef3568cb33ea9680
with:
restrict-gradle: 'true'

- name: Determine new patched RN version
id: getNewPatchedVersion
run: echo "NEW_PATCHED_VERSION=$(./.github/scripts/getNewPatchedRNVersion.sh)" >> "$GITHUB_OUTPUT"
Expand Down
16 changes: 16 additions & 0 deletions .github/workflows/publishReactNativeiOSArtifacts.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,22 @@ jobs:
path: /tmp/ios-artifacts
merge-multiple: true

- name: Get Java version
id: get-java-version
uses: ./.github/actions/composite/getJavaVersion

- name: Setup Java
# v5.2.0
uses: actions/setup-java@be666c2fcd27ec809703dec50e508c2fdc7f6654
with:
distribution: oracle
java-version: ${{ steps.get-java-version.outputs.version }}

- name: Block compromised Java certificates
uses: Expensify/GitHub-Actions/block-compromised-java-certificates@b70c378d6cfae84f6844379eef3568cb33ea9680
with:
restrict-gradle: 'true'

- name: Publish to GitHub Packages Maven
run: ./android/gradlew -p scripts/artifacts-utils/ios/publish publish -PartifactsDir="/tmp/ios-artifacts" -PpatchedVersion="${PATCHED_VERSION}" -PpatchesHash="${PATCHES_HASH}" -PpackageName="${PACKAGE_NAME}"
env:
Expand Down
19 changes: 19 additions & 0 deletions .github/workflows/remote-build-android.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,23 @@ jobs:
role-duration-seconds: 21600
aws-region: us-east-1

- name: Get Java version
id: get-java-version
uses: ./.github/actions/composite/getJavaVersion

- name: Setup Java
# v5.2.0
uses: actions/setup-java@be666c2fcd27ec809703dec50e508c2fdc7f6654
with:
distribution: adopt
java-version: ${{ steps.get-java-version.outputs.version }}
cache: gradle

- name: Block compromised Java certificates
uses: Expensify/GitHub-Actions/block-compromised-java-certificates@b70c378d6cfae84f6844379eef3568cb33ea9680
with:
restrict-gradle: 'true'

- name: Rock Remote Build - Android
# rock v3
uses: callstackincubator/android@1a7d52dfe3ca195ccbe5ad2f06c15f2fc3835115
Expand All @@ -98,6 +115,8 @@ jobs:
GITHUB_TOKEN: ${{ github.token }}
IS_HYBRID_APP: ${{ matrix.is_hybrid_build }}
with:
# Java is installed and protected before Rock can run Gradle.
setup-java: false
variant: ${{ matrix.variant }}
rock-build-extra-params: '--extra-params -PreactNativeArchitectures=arm64-v8a,x86_64'
comment-bot: false
Loading