Repository navigation
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
# Conflicts: # src/ONYXKEYS.ts
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
ReviewI found two issues to fix before merge. The drag logic, the 1. A failing CI test comes from this PR. 2. The resizable width also applies when the beta is off.
This causes two visible effects for users without the beta:
To fix both, have The other non-passing checks are |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 66d9d7f61b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@Krishna2323 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d6788ab063
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| drag.liveWidth = liveWidth; | ||
| }, | ||
| onEnd: ({liveWidth}) => { | ||
| setIsDragging(false); |
There was a problem hiding this comment.
Reset hover when the captured RHP drag ends
On web, if the pointer is released or cancelled outside the 12px handle, pointer capture can suppress pointerleave (the table caller explicitly hit-tests in syncGripHover because release/lost capture does not reliably fire boundary events). This callback clears only isDragging, leaving isHovered true from the initial enter, so (isHovered || isDragging) keeps the green line rendered until the user crosses the handle again; synchronize hover from the end event here as useColumnResize does.
Useful? React with 👍 / 👎.
Explanation of Change
Behind the
resizableRHPbeta, users can drag the single RHP's left edge on wide web layouts to resize it (380px to the wide RHP width minus 40px). Mid-drag the width is written to a scoped--rhp-widthCSS variable, so nothing re-renders. On release it's saved to Onyx (singleRHPWidth). The drag lifecycle and size math are now shared with resizable table columns.Fixed Issues
$ #103561
PROPOSAL:
Tests
resizableRHPbeta. On a wide web window, go to Account > Profile and open Timezone in the RHP.col-resizeand a green line shows just outside the card's left border.resizableRHPbeta enabled, open an expense report in the RHP (a wide or super-wide RHP).resizableTableColumnsbeta and open a table with resizable columns (for example, Workspace > Members).Offline tests
resizableRHPbeta enabled, open a single RHP and drag its left edge to a new width.QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari