Repository navigation
Native Account keeps the tab bar with no item selected under the Insights beta - #104491
sumo-slonik wants to merge 6 commits into
Conversation
|
|
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
…ck button under the Insights beta
…dden via transparent indicator, iOS-only RNS prop
… on bottom-tabs patch 003
56afa3c to
0c0fa30
Compare
…thout the beta; trim tests to the Home tap
…ome is drawn unselected, iOS lens restored natively
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@shawnborton @ZhenjaHorbach One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Explanation of Change
With the Insights beta, native Account keeps the tab bar with no item selected and no back arrow, like mWeb.
Known limitation: VoiceOver and TalkBack may still announce Home as selected while Account is shown.
Fixed Issues
$ #104197
PROPOSAL: N/A
Tests
With the
insightsPagebeta on, narrow layout, iOS and Android native:Offline tests
Same as Tests.
QA Steps
Same as Tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-10-20.at.21.13.24.mov
Android: mWeb Chrome
N/A, the change is native only.
iOS: Native
Screen.Recording.2026-10-20.at.21.13.08.mov
iOS: mWeb Safari
N/A, the change is native only.
MacOS: Chrome / Safari
N/A, the change is native only.