[jmgraa]

Explanation of Change

Previously, SubmitDetailsPage called snapshotUserLocation() on mount and held a reactive useOnyx(ONYXKEYS.USER_LOCATION) subscription. Querying device GPS permissions and writing coordinates into Onyx inside the ShareExtensionOpenSubmitFlow telemetry span caused main-thread latency and triggered unnecessary component re-renders - even though GPS coordinates are only needed at submit time to attach to the expense payload, never during UI rendering.

This PR optimizes the share extension flow by pre-warming location in ShareRootPage and converting SubmitDetailsPage to a one-shot lazy read via Onyx.get:

• Dependency note: This change builds on the public Onyx.get() API introduced in [email protected] PR #102135. Once PR #102135 is merged into main, this PR will be rebased cleanly as a single commit containing only the GPS and Share Extension changes.
• src/pages/Share/ShareRootPage.tsx: Pre-warms device GPS via snapshotUserLocation() in the background as soon as a scannable receipt file is processed, caching coordinates while the user picks a recipient.
• src/pages/Share/SubmitDetailsPage.tsx: Removes the mount-time snapshotUserLocation() effect and drops the reactive useOnyx(ONYXKEYS.USER_LOCATION) subscription. Replaces it with a lazy await Onyx.get(ONYXKEYS.USER_LOCATION) call inside onSuccess right when the user submits, keeping device queries off the open span and preventing late GPS writes from re-rendering the page.
• tests/: Adds tests/ui/ShareRootPageLocationTest.tsx to verify early GPS caching and permission error resilience; updates tests/ui/SubmitDetailsPageTest.tsx to ensure neither opening the details page nor confirming reads the hardware device.

Fixed Issues

$ #95335
PROPOSAL:

Tests

1. Ensure location permission is granted for Expensify in device system settings.
2. From Photos or Files, share a receipt image (JPEG/PNG) to the Expensify Share Extension.
3. Select any recipient on ShareRootPage to navigate to SubmitDetailsPage.
4. Verify the details screen opens immediately without lag or re-render stutter.
5. Tap Submit and verify:
   • The expense is created successfully.
   • GPS coordinates (gpsPoint) captured during pre-warming are attached to the expense request.
6. Revoke location permission in device settings (or share a non-receipt file) and repeat: verify sharing and submitting completes normally without blocking or errors.

• Verify that no errors appear in the JS console

Offline tests

1. Enable Airplane mode on the device.
2. Share a receipt image via the Share Extension and submit the expense.
3. Verify the expense is queued offline.
4. Disable Airplane mode, reconnect to the internet, and verify the expense syncs successfully.

QA Steps

1. Ensure location permission is granted for Expensify in device settings.
2. From Photos or Files, share a receipt image (JPEG/PNG) to the Expensify Share Extension.
3. Select any recipient on ShareRootPage to navigate to SubmitDetailsPage.
4. Verify the details screen opens smoothly without stutter or delay.
5. Tap Submit and verify the expense is created and submitted successfully without any errors.
6. Revoke location permission in device settings (or share a non-receipt file like MP4) and repeat: verify sharing and submitting complete normally without errors.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If the PR adds or modifies the UI:
  • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
  • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
  • I verified all new/changed elements have meaningful accessible names and roles.
  • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

[github-actions]

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️