[No QA] Show reclaimable tax details in the added distance rate change log by c3024 · Pull Request #104431 · Expensify/App

c3024 · 2026-10-20T02:45:28Z

Explanation of Change

The "added rate" distance change log now ends with , with <amount>/<unit> tax reclaimable under "<taxRateName>" when the log has taxClaimablePercentage and taxRateName. The amount is rate × taxClaimablePercentage. Logs without these fields render as before.

Auth side: https://github.com/Expensify/Auth/pull/25666

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/692145
PROPOSAL: N/A

Tests

The backend does not send these fields yet (#692142 adds them for UK fuel-band rates), so these steps add them locally through Onyx in the browser console.

Open a GBP workspace with distance rates enabled.
Go to Workspace > Distance rates and add a rate named "Test" of 0.55 with a start date of October 1, 2026.
Open the workspace #admins room and verify the log reads added "Test" rate of £0.55/mile, valid from October 1, 2026.

Copy the reportID from the URL of the chat showing that log and run this in the browser console, replacing REPORT_ID:

const key = 'reportActions_REPORT_ID';
const setTax = (originalMessage) => Onyx.get(key).then((actions) => Onyx.merge(key, {[Object.keys(actions).find((id) => actions[id]?.actionName === 'POLICYCHANGELOG_ADD_CUSTOM_UNIT_RATE')]: {originalMessage}}));
setTax({taxClaimablePercentage: 0.2545454545454545, taxRateName: 'Standard VAT (20%)'});

Verify the log reads added "Test" rate of £0.55/mile, valid from October 1, 2026, with £0.14/mile tax reclaimable under "Standard VAT (20%)".
Run setTax({taxClaimablePercentage: 0}) and verify the suffix shows £0.00/mile.
Run setTax({taxRateName: null}) and verify the suffix is gone.

Verify that no errors appear in the JS console

Offline tests

Go offline.
Open the workspace #admins room.
Verify the existing "added rate" logs render the same as online.

QA Steps

No QA. The backend doesn't send these fields yet, so the suffix can only be checked with the dev-only console steps above.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

When the log has taxClaimablePercentage and taxRateName, append the reclaimable amount per unit (rate x taxClaimablePercentage) and the tax rate name.

melvin-bot · 2026-10-20T02:45:55Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx bun ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx bun ./scripts/generateTranslations.ts --compare-ref main

codecov · 2026-10-20T02:51:05Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/libs/ReportActionsUtils.ts	`84.14% <80.00%> (+0.06%)`	⬆️
... and 11 files with indirect coverage changes

melvin-bot · 2026-10-20T05:54:59Z

@thesahindia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector · 2026-10-20T05:55:02Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-20T06:08:39.939985Z	`8478246`	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

joekaufmanexpensify

Good for product

neil-marcellini

Looks great thanks!

neil-marcellini · 2026-10-20T20:38:11Z

No C+ needed.

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If the PR adds or modifies the UI:
- I asked an AI agent to review the changes for accessibility issues and addressed its findings.
- I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
- I verified all new/changed elements have meaningful accessible names and roles.
- I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

github-actions · 2026-10-20T20:47:46Z

🚧 neil-marcellini has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-10-20T20:49:10Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-10-20T20:53:00Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #104431.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-b2610a3-f8df561-c33da868d6f492e8b21d9adeda665a1a939e4c0d/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-b2610a3-f8df561-2da73a2ed1b3fba7d1c2f595449b33acdcc0806d/index.html

Web 🕸️
https://104431.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-10-21T20:08:57Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.5.16-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-10-21T20:14:31Z

No help site update is needed. This PR only adds a tax suffix to the "added rate" log message in the #admins room, which explains itself in the app, and the backend doesn't send the new fields yet.

view run

OSBotify · 2026-10-22T19:23:05Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.5.18-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	cancelled 🔪

MelvinBot · 2026-10-22T19:27:22Z

No help site update needed. This PR only adds a tax reclaimable suffix to the "added rate" change log in the #admins room, and no article quotes that log text or says anything this change makes incorrect.

view run

OSBotify · 2026-10-23T16:54:13Z

🚀 Deployed to production by https://github.com/grgia in version: 9.5.18-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

Show reclaimable tax details in the added distance rate change log

8478246

When the log has taxClaimablePercentage and taxRateName, append the reclaimable amount per unit (rate x taxClaimablePercentage) and the tax rate name.

melvin-bot Bot assigned c3024 Oct 20, 2026

c3024 changed the title ~~Show reclaimable tax details in the added distance rate change log~~ [No QA] Show reclaimable tax details in the added distance rate change log Oct 20, 2026

c3024 marked this pull request as ready for review October 20, 2026 05:54

c3024 requested review from a team as code owners October 20, 2026 05:54

melvin-bot Bot requested review from thesahindia and removed request for a team October 20, 2026 05:54

melvin-bot Bot requested review from joekaufmanexpensify and removed request for a team October 20, 2026 05:54

neil-marcellini self-requested a review October 20, 2026 14:12

joekaufmanexpensify approved these changes Oct 20, 2026

View reviewed changes

neil-marcellini approved these changes Oct 20, 2026

View reviewed changes

neil-marcellini removed the request for review from thesahindia October 20, 2026 20:38

neil-marcellini merged commit b2610a3 into Expensify:main Oct 20, 2026
46 of 49 checks passed

OSBotify mentioned this pull request Oct 21, 2026

Deploy Checklist: New Expensify 2026-10-21 #104620

Closed

83 tasks done

Conversation

c3024 commented Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Oct 20, 2026

Uh oh!

codecov Bot commented Oct 20, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Oct 20, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

neil-marcellini left a comment

Choose a reason for hiding this comment

Uh oh!

neil-marcellini commented Oct 20, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

github-actions Bot commented Oct 20, 2026

Uh oh!

OSBotify commented Oct 20, 2026

Uh oh!

github-actions Bot commented Oct 20, 2026

Uh oh!

OSBotify commented Oct 21, 2026

Uh oh!

MelvinBot commented Oct 21, 2026

Uh oh!

OSBotify commented Oct 22, 2026

Uh oh!

MelvinBot commented Oct 22, 2026

Uh oh!

OSBotify commented Oct 23, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

c3024 commented Oct 20, 2026 •

edited

Loading

codecov Bot commented Oct 20, 2026 •

edited by github-actions Bot

Loading

chatgpt-codex-connector Bot commented Oct 20, 2026 •

edited

Loading