Repository navigation
[DO NOT MERGE] [No QA] Debug logging for UK Add to Apple Wallet MFA failure - #104430
Draft
rafecolton wants to merge 3 commits into
Draft
rafecolton wants to merge 3 commits into
rafecolton wants to merge 3 commits into
Conversation
Logs the raw native wallet results, MFA authorize/action lifecycle, and abort timing to server logs and Sentry, tagged [WalletDebug].
Contributor
|
🚧 rafecolton has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
Contributor
|
🚧 rafecolton has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
Contributor
|
🚧 rafecolton has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
43 tasks done
Contributor
|
🚧 rafecolton has triggered a test Expensify/App build. You can view the workflow run here. |
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
DO NOT MERGE. This PR exists only to produce an ad hoc build with temporary debug logging.
It sits on top of #104179. On the ad hoc build for that PR, adding a UK Expensify Card to Apple Wallet fails: the MFA flow shows "Verification failed" with
Local: Unrecognized local errorabout 0.5s after Face ID. The Apple Wallet sheet still opens afterward, andCreateDigitalWalletsucceeds on the server with the signed challenge.This PR adds logs tagged
[WalletDebug]that go to both server logs and Sentry:src/libs/Wallet/index.ios.ts: the MFA path calls a copy ofaddCardToAppleWalletfrom@expensify/react-native-wallet0.1.22 that logs the raw native results ofIOSPresentAddPaymentPassViewandIOSHandleAddPaymentPassResponse. It also logs each issuer callback, abort signal events,onCardActivatedevents, and the app state at each step. Each call gets an ID.AddToDigitalWallet.ts: logs when the scenario action starts and what it gets back.MultifactorAuthenticationMainContext.tsx: logs eachprocess()run, authorize start and result, action dispatch and return, aborts, cancel, and flow errors.AddToWalletButton: logs each press.No card data, nonces, certificates, payloads, or signed challenges are logged. Only key names, booleans, lengths, and status values are.
Fixed Issues
For https://github.com/Expensify/Expensify/issues/692372
PROPOSAL:
Tests
[WalletDebug]lines for the attempt.Offline tests
N/A, this is temporary debug logging.
QA Steps
[No QA] This PR will not be merged.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari