Skip to content

[DO NOT MERGE] [No QA] Debug logging for UK Add to Apple Wallet MFA failure - #104430

Draft
rafecolton wants to merge 3 commits into
chuckdries/mfa-tokenizationfrom
rafecolton/mfa-wallet-debug-logs
Draft

rafecolton wants to merge 3 commits into
chuckdries/mfa-tokenizationfrom
rafecolton/mfa-wallet-debug-logs

Conversation

@rafecolton

Copy link
Copy Markdown
Member

Explanation of Change

DO NOT MERGE. This PR exists only to produce an ad hoc build with temporary debug logging.

It sits on top of #104179. On the ad hoc build for that PR, adding a UK Expensify Card to Apple Wallet fails: the MFA flow shows "Verification failed" with Local: Unrecognized local error about 0.5s after Face ID. The Apple Wallet sheet still opens afterward, and CreateDigitalWallet succeeds on the server with the signed challenge.

This PR adds logs tagged [WalletDebug] that go to both server logs and Sentry:

  • src/libs/Wallet/index.ios.ts: the MFA path calls a copy of addCardToAppleWallet from @expensify/react-native-wallet 0.1.22 that logs the raw native results of IOSPresentAddPaymentPassView and IOSHandleAddPaymentPassResponse. It also logs each issuer callback, abort signal events, onCardActivated events, and the app state at each step. Each call gets an ID.
  • AddToDigitalWallet.ts: logs when the scenario action starts and what it gets back.
  • MultifactorAuthenticationMainContext.tsx: logs each process() run, authorize start and result, action dispatch and return, aborts, cancel, and flow errors.
  • AddToWalletButton: logs each press.
  • A Sentry event is sent at the end of each wallet attempt and on each MFA flow error, so the breadcrumb trail gets uploaded.

No card data, nonces, certificates, payloads, or signed challenges are logged. Only key names, booleans, lengths, and status values are.

Fixed Issues

For https://github.com/Expensify/Expensify/issues/692372
PROPOSAL:

Tests

  1. Install the iOS ad hoc build from this PR on a physical iPhone.
  2. Sign in to an account with a UK Expensify Card that is not in Apple Wallet.
  3. Open Wallet and select the UK card.
  4. Tap Add to Apple Wallet.
  5. Complete Face ID.
  6. Continue through the Apple Wallet sheet if it appears.
  7. Send the app to the background so the logs flush.
  8. Confirm the server logs for the account contain [WalletDebug] lines for the attempt.
  • Verify that no errors appear in the JS console

Offline tests

N/A, this is temporary debug logging.

QA Steps

[No QA] This PR will not be merged.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Logs the raw native wallet results, MFA authorize/action lifecycle, and abort
timing to server logs and Sentry, tagged [WalletDebug].
@github-actions

Copy link
Copy Markdown
Contributor

🚧 rafecolton has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@github-actions

Copy link
Copy Markdown
Contributor

🚧 rafecolton has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@github-actions

Copy link
Copy Markdown
Contributor

🚧 rafecolton has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@github-actions

Copy link
Copy Markdown
Contributor

🚧 rafecolton has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

Copy link
Copy Markdown
Contributor

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant