Repository navigation
[NoQA][Business Central][R3] Change phrasing for sync reimbursed reports feature - #104429
Merged
Merged
Conversation
melvin-bot
Bot
requested review from
garrettmknight
and removed request for
a team
October 20, 2026 01:06
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
melvin-bot
Bot
requested review from
arosiclair
and removed request for
a team
October 20, 2026 01:07
|
@arosiclair Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Contributor
Author
|
No C+ review needed for this |
Contributor
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index aff85e69..57361655 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -9316,9 +9316,9 @@ Fügen Sie weitere Ausgabelimits hinzu, um den Cashflow Ihres Unternehmens zu sc
exportToNextOpenPeriodDescription:
'Wenn ein Bericht auf eine geschlossene Periode in Dynamics 365 Business Central datiert ist, wird er in die nächste offene Periode exportiert.',
syncReimbursedReports: 'Erstattete Berichte synchronisieren',
- syncReimbursedReportsDescription: 'Wenn ein Bericht per ACH bezahlt wird, wird in diesem Konto eine Rechnungszahlung erstellt.',
+ syncReimbursedReportsDescription: 'Wenn ein Bericht per ACH bezahlt wird, wird in diesem Konto eine allgemeine Journalzeile erzeugt.',
reimbursementBankAccount: {
- label: 'Rechnungskonto',
+ label: 'Zahlungskonto',
description: 'Wählen Sie aus, von wo Sie Rechnungen bezahlen möchten, und wir erstellen die Zahlung in Dynamics 365 Business Central.',
},
syncExpensifyCardSettlements: 'Expensify Karte-Abrechnungen synchronisieren',
diff --git a/src/languages/el.ts b/src/languages/el.ts
index cda27383..62cf56fb 100644
--- a/src/languages/el.ts
+++ b/src/languages/el.ts
@@ -9479,9 +9479,9 @@ ${reportName}`,
exportToNextOpenPeriod: 'Εξαγωγή στην επόμενη ανοικτή περίοδο',
exportToNextOpenPeriodDescription: 'Όταν μια αναφορά έχει ημερομηνία σε κλειστή περίοδο του Dynamics 365 Business Central, εξάγεται στην επόμενη ανοιχτή περίοδο.',
syncReimbursedReports: 'Συγχρονισμός αποζημιωμένων αναφορών',
- syncReimbursedReportsDescription: 'Όταν μια αναφορά πληρωθεί μέσω ACH, θα δημιουργηθεί μια πληρωμή λογαριασμού σε αυτόν τον λογαριασμό.',
+ syncReimbursedReportsDescription: 'Όταν μια αναφορά εξοφλείται μέσω ACH, θα δημιουργείται μια γραμμή γενικής λογιστικής εγγραφής σε αυτόν τον λογαριασμό.',
reimbursementBankAccount: {
- label: 'Λογαριασμός πληρωμής λογαριασμών',
+ label: 'Τραπεζικός λογαριασμός πληρωμών',
description: 'Επιλέξτε από πού θα πληρώνονται οι λογαριασμοί και θα δημιουργήσουμε την πληρωμή στο Dynamics 365 Business Central.',
},
syncExpensifyCardSettlements: 'Συγχρονισμός διακανονισμών Κάρτας Expensify',
diff --git a/src/languages/es.ts b/src/languages/es.ts
index d7ad5a7a..77379dd3 100644
--- a/src/languages/es.ts
+++ b/src/languages/es.ts
@@ -9133,11 +9133,8 @@ ${reportName}`,
exportToNextOpenPeriod: 'Exportar al siguiente período abierto',
exportToNextOpenPeriodDescription: 'Cuando la fecha de un informe cae en un período cerrado de Dynamics 365 Business Central, se exporta al siguiente período abierto.',
syncReimbursedReports: 'Sincronizar informes reembolsados',
- syncReimbursedReportsDescription: 'Cuando un informe se paga mediante ACH, se generará un pago de factura en esta cuenta.',
- reimbursementBankAccount: {
- label: 'Cuenta de pago de facturas',
- description: 'Elige desde dónde pagar las facturas y crearemos el pago en Dynamics 365 Business Central.',
- },
+ syncReimbursedReportsDescription: 'Cuando un informe se pague mediante ACH, se generará un asiento de diario general en esta cuenta.',
+ reimbursementBankAccount: {label: 'Cuenta bancaria de pago', description: 'Elige desde dónde pagar las facturas y crearemos el pago en Dynamics 365 Business Central.'},
syncExpensifyCardSettlements: 'Sincronizar liquidaciones de la Tarjeta Expensify',
settlementsBankAccount: {
label: 'Cuenta de liquidación de la Tarjeta Expensify',
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index a089625e..96b6f74b 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -9343,9 +9343,9 @@ Ajoutez davantage de règles de dépenses pour protéger la trésorerie de l’e
exportToNextOpenPeriodDescription:
'Lorsqu’une note de frais est datée dans une période clôturée de Dynamics 365 Business Central, elle est exportée vers la période ouverte suivante.',
syncReimbursedReports: 'Synchroniser les notes de frais remboursées',
- syncReimbursedReportsDescription: 'Lorsqu’une note de frais est payée par virement ACH, un paiement de facture sera généré sur ce compte.',
+ syncReimbursedReportsDescription: 'Lorsqu’une note de frais est payée par ACH, une écriture de journal général sera générée dans ce compte.',
reimbursementBankAccount: {
- label: 'Compte de paiement des factures',
+ label: 'Compte bancaire de paiement',
description: 'Choisissez d’où payer les factures et nous créerons le paiement dans Dynamics 365 Business Central.',
},
syncExpensifyCardSettlements: 'Synchroniser les règlements de Carte Expensify',
diff --git a/src/languages/it.ts b/src/languages/it.ts
index 6eb2a2e9..e3fbfc3c 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -9258,11 +9258,8 @@ Aggiungi altre regole di spesa per proteggere il flusso di cassa aziendale.`,
exportToNextOpenPeriod: 'Esporta nel prossimo periodo aperto',
exportToNextOpenPeriodDescription: 'Quando un report ha una data in un periodo chiuso di Dynamics 365 Business Central, viene esportato nel periodo aperto successivo.',
syncReimbursedReports: 'Sincronizza i report rimborsati',
- syncReimbursedReportsDescription: 'Quando un resoconto viene pagato tramite ACH, verrà generato un pagamento di fattura in questo conto.',
- reimbursementBankAccount: {
- label: 'Conto per il pagamento delle bollette',
- description: 'Scegli da dove pagare le fatture e creeremo il pagamento in Dynamics 365 Business Central.',
- },
+ syncReimbursedReportsDescription: 'Quando un report viene pagato tramite ACH, in questo conto verrà generata una riga di prima nota generale.',
+ reimbursementBankAccount: {label: 'Conto bancario di pagamento', description: 'Scegli da dove pagare le fatture e creeremo il pagamento in Dynamics 365 Business Central.'},
syncExpensifyCardSettlements: 'Sincronizza le liquidazioni della Carta Expensify',
settlementsBankAccount: {
label: 'Conto di regolamento Carta Expensify',
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 58a13bfc..dad8171d 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -9133,11 +9133,8 @@ ${reportName}`,
exportToNextOpenPeriod: '次の未締め期間にエクスポート',
exportToNextOpenPeriodDescription: 'レポートの日付が Dynamics 365 Business Central の締め済み期間にある場合、次の未締め期間にエクスポートします。',
syncReimbursedReports: '精算済みレポートを同期',
- syncReimbursedReportsDescription: 'レポートが ACH で支払われると、この口座に支払伝票が作成されます。',
- reimbursementBankAccount: {
- label: '請求支払用口座',
- description: '請求書の支払い元を選択すると、Dynamics 365 Business Central 内に支払いを作成します。',
- },
+ syncReimbursedReportsDescription: 'レポートが ACH で支払われると、この勘定科目に総勘定元帳の仕訳行が作成されます。',
+ reimbursementBankAccount: {label: '支払用銀行口座', description: '請求書の支払い元を選択すると、Dynamics 365 Business Central 内に支払いを作成します。'},
syncExpensifyCardSettlements: 'Expensify カード清算を同期する',
settlementsBankAccount: {
label: 'Expensify カードの決済口座',
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 55d382cb..98414394 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -9233,9 +9233,9 @@ er bestedingsregels toe om de kasstroom van het bedrijf te beschermen.`,
exportToNextOpenPeriodDescription:
'Als een rapport is gedateerd in een afgesloten periode in Dynamics 365 Business Central, wordt het geëxporteerd naar de volgende open periode.',
syncReimbursedReports: 'Vergoede rapporten synchroniseren',
- syncReimbursedReportsDescription: 'Wanneer een rapport via ACH wordt betaald, wordt er in deze rekening een rekeningbetaling aangemaakt.',
+ syncReimbursedReportsDescription: 'Wanneer een rapport via ACH wordt betaald, wordt er in deze rekening een journaalpostregel aangemaakt.',
reimbursementBankAccount: {
- label: 'Rekening voor het betalen van rekeningen',
+ label: 'Betaalbankrekening',
description: 'Kies van waar je rekeningen wilt betalen en we maken de betaling aan in Dynamics 365 Business Central.',
},
syncExpensifyCardSettlements: 'Expensify Kaartafrekeningen synchroniseren',
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index 17a89282..ccd5a07e 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -9248,9 +9248,9 @@ Dodaj więcej zasad wydatków, żeby chronić płynność finansową firmy.`,
exportToNextOpenPeriod: 'Eksportuj do następnego otwartego okresu',
exportToNextOpenPeriodDescription: 'Gdy raport ma datę w zamkniętym okresie w Dynamics 365 Business Central, zostanie wyeksportowany do następnego otwartego okresu.',
syncReimbursedReports: 'Synchronizuj rozliczone raporty',
- syncReimbursedReportsDescription: 'Gdy raport zostanie opłacony przez ACH, na tym koncie zostanie wygenerowana płatność rachunku.',
+ syncReimbursedReportsDescription: 'Gdy raport zostanie opłacony przez ACH, w tym koncie zostanie wygenerowany wiersz dziennika ogólnego.',
reimbursementBankAccount: {
- label: 'Konto do opłacania rachunków',
+ label: 'Rachunek bankowy do płatności',
description: 'Wybierz, z którego konta chcesz opłacać rachunki, a my utworzymy płatność w Dynamics 365 Business Central.',
},
syncExpensifyCardSettlements: 'Synchronizuj rozliczenia Karty Expensify',
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 274d6290..99456040 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -9238,9 +9238,9 @@ Adicione mais regras de gasto para proteger o fluxo de caixa da empresa.`,
exportToNextOpenPeriod: 'Exportar para o próximo período em aberto',
exportToNextOpenPeriodDescription: 'Quando um relatório tem data em um período fechado do Dynamics 365 Business Central, ele é exportado para o próximo período aberto.',
syncReimbursedReports: 'Sincronizar relatórios reembolsados',
- syncReimbursedReportsDescription: 'Quando um relatório for pago via ACH, um pagamento de conta será gerado nesta conta.',
+ syncReimbursedReportsDescription: 'Quando um relatório é pago via ACH, uma linha de lançamento contábil será gerada nesta conta.',
reimbursementBankAccount: {
- label: 'Conta de pagamento de contas',
+ label: 'Conta bancária de pagamento',
description: 'Escolha de onde pagar as contas e nós vamos criar o pagamento no Dynamics 365 Business Central.',
},
syncExpensifyCardSettlements: 'Sincronizar liquidações do Cartão Expensify',
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index 79dafb43..97462175 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -8892,11 +8892,8 @@ ${reportName}`,
exportToNextOpenPeriod: '导出到下一个未结会计期间',
exportToNextOpenPeriodDescription: '当报告日期位于 Dynamics 365 Business Central 的已关闭期间时，将其导出到下一个未关闭期间。',
syncReimbursedReports: '同步已报销报表',
- syncReimbursedReportsDescription: '当报表通过 ACH 支付时，将在此账户中生成一笔账单付款。',
- reimbursementBankAccount: {
- label: '账单支付账户',
- description: '选择从哪里支付账单，我们会在 Dynamics 365 Business Central 中创建付款。',
- },
+ syncReimbursedReportsDescription: '当报表通过 ACH 支付时，将在此科目中生成一条普通日记账分录。',
+ reimbursementBankAccount: {label: '付款银行账户', description: '选择从哪里支付账单，我们会在 Dynamics 365 Business Central 中创建付款。'},
syncExpensifyCardSettlements: '同步 Expensify 卡结算',
settlementsBankAccount: {
label: 'Expensify 卡结算账户',
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
NikkiWines
requested changes
Oct 20, 2026
NikkiWines
left a comment
NikkiWines
left a comment
Contributor
There was a problem hiding this comment.
Oh actually @francoisl we do need the translations for this
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
Contributor
Author
Yes I was waiting for approval on the english text first, going to apply it now |
NikkiWines
approved these changes
Oct 20, 2026
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
|
🚧 NikkiWines has triggered a test Expensify/App build. You can view the workflow run here. |
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
58 of 87 tasks
Contributor
|
🚀 Deployed to staging by https://github.com/NikkiWines in version: 9.5.16-0 🚀
|
Contributor
|
No help site update needed. This PR only rewords two labels in the Dynamics 365 Business Central integration, which is still behind the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
The Business Central integration won't be creating "bills" for reimbursement syncing, yet the text for the feature was copied from other integrations that do, and it makes little sense at the moment. This essentially replaces "bill" with "journal". Suggestions are welcome because I'm not sure if we also need to update the "Choose where to pay bills from" sentence - from a customer's point of view, is the bill here the expense report?
Fixed Issues
Part of https://github.com/Expensify/Expensify/issues/686634
Tests
QA Steps
N/A
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
MacOS: Chrome / Safari