Repository navigation
[No QA] Enable Workers Issues for the NewDot Cloudflare Worker - #104398
Conversation
Issues groups uncaught exceptions, 5xx responses and console.error calls. It has to be in wrangler.jsonc, because a deploy without it turns Issues off again, and each environment's observability block replaces the top-level one.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Also created a complimentary follow-up: #104428 |
|
🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.5.15-1 🚀
|
Explanation of Change
Enables Workers Issues on the NewDot Cloudflare Worker, so uncaught exceptions,
5xxresponses andconsole.errorcalls are grouped into issues in the Cloudflare dashboard.It has to be in
wrangler.jsonc: turning it on in the dashboard doesn't last, because the nextwrangler deploywithout the setting turns it off again, and CI deploys the staging Worker on every staging deploy. Each environment'sobservabilityblock replaces the top-level one rather than merging with it, soissuesis set at the top level (inherited bytest-staging) and instagingandproduction.Issues is free during its open beta.
Fixed Issues
For https://github.com/Expensify/Expensify/issues/688126
PROPOSAL:
Tests
web/cloudflare-worker, runnpm testandnpm run typecheckand verify both pass.test-staging,stagingandproductioneach resolve to anobservabilityconfig withissues.enabled: true(for example with wrangler'sunstable_readConfig).npx wrangler deploy --dry-run --env stagingwith a web build indist/and verify it succeeds.staging-new-expensify-assetsWorker's Settings > Observability is on.Offline tests
N/A. Worker configuration only.
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
No QA. Monitoring configuration only; responses are unchanged.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari