Skip to content

[No QA] Enable Workers Issues for the NewDot Cloudflare Worker - #104398

Merged
roryabraham merged 1 commit into
mainfrom
jpersaud-worker-issues
Oct 20, 2026
Merged

roryabraham merged 1 commit into
mainfrom
jpersaud-worker-issues

Conversation

@justinpersaud

Copy link
Copy Markdown
Contributor

Explanation of Change

Enables Workers Issues on the NewDot Cloudflare Worker, so uncaught exceptions, 5xx responses and console.error calls are grouped into issues in the Cloudflare dashboard.

It has to be in wrangler.jsonc: turning it on in the dashboard doesn't last, because the next wrangler deploy without the setting turns it off again, and CI deploys the staging Worker on every staging deploy. Each environment's observability block replaces the top-level one rather than merging with it, so issues is set at the top level (inherited by test-staging) and in staging and production.

Issues is free during its open beta.

Fixed Issues

For https://github.com/Expensify/Expensify/issues/688126
PROPOSAL:

Tests

  1. In web/cloudflare-worker, run npm test and npm run typecheck and verify both pass.
  2. Verify test-staging, staging and production each resolve to an observability config with issues.enabled: true (for example with wrangler's unstable_readConfig).
  3. Run npx wrangler deploy --dry-run --env staging with a web build in dist/ and verify it succeeds.
  4. After merging, on the next staging deploy, verify the Issues toggle under the staging-new-expensify-assets Worker's Settings > Observability is on.
  • Verify that no errors appear in the JS console

Offline tests

N/A. Worker configuration only.

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

No QA. Monitoring configuration only; responses are unchanged.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Issues groups uncaught exceptions, 5xx responses and console.error calls. It has to be in wrangler.jsonc, because a deploy without it turns Issues off again, and each environment's observability block replaces the top-level one.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-19T20:35:23.119093Z 497e10f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@roryabraham
roryabraham merged commit 8775393 into main Oct 20, 2026
27 of 28 checks passed
@roryabraham
roryabraham deleted the jpersaud-worker-issues branch October 20, 2026 00:48
@roryabraham

Copy link
Copy Markdown
Contributor

Also created a complimentary follow-up: #104428

@github-actions

Copy link
Copy Markdown
Contributor

🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.5.15-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants