Repository navigation
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx bun ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
6bc3f30 to
e0b0f30
Compare
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index 5dd7a081..c6b2a1b5 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -2828,6 +2828,7 @@ const translations: TranslationDeepObject<typeof en> = {
accountRequiresAttention: 'Dieses Konto erfordert Ihre Aufmerksamkeit',
unlock: 'Entsperren',
},
+ wiseGlobalReimbursementsIntro: {title: 'Globale Rückerstattungen einrichten?', subtitle: 'Zahlen Sie Mitglieder weltweit in ihrer lokalen Währung.', getStarted: "Los geht's"},
},
addCardToDigitalWallet: {
title: ({walletName}: {walletName: string}) => `Karte zu ${walletName} hinzufügen`,
diff --git a/src/languages/el.ts b/src/languages/el.ts
index 3a0a2f2c..e774a8df 100644
--- a/src/languages/el.ts
+++ b/src/languages/el.ts
@@ -2884,6 +2884,7 @@ const translations: TranslationDeepObject<typeof en> = {
accountRequiresAttention: 'Αυτός ο λογαριασμός χρειάζεται προσοχή',
unlock: 'Ξεκλείδωμα',
},
+ wiseGlobalReimbursementsIntro: {title: 'Να ρυθμιστούν οι παγκόσμιες αποζημιώσεις;', subtitle: 'Πληρώστε μέλη παγκοσμίως στο τοπικό τους νόμισμα.', getStarted: 'Ξεκινήστε'},
},
addCardToDigitalWallet: {
title: ({walletName}: {walletName: string}) => `Προσθήκη κάρτας στο ${walletName}`,
diff --git a/src/languages/es.ts b/src/languages/es.ts
index 1255ad65..c58e926a 100644
--- a/src/languages/es.ts
+++ b/src/languages/es.ts
@@ -2738,6 +2738,7 @@ const translations: TranslationDeepObject<typeof en> = {
accountRequiresAttention: 'Esta cuenta requiere atención',
unlock: 'Desbloquear',
},
+ wiseGlobalReimbursementsIntro: {title: '¿Configurar reembolsos globales?', subtitle: 'Paga a miembros de todo el mundo en su moneda local.', getStarted: 'Empieza'},
},
addCardToDigitalWallet: {
title: ({walletName}: {walletName: string}) => `Añadir tarjeta a ${walletName}`,
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index c629e2bd..3808f762 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -2833,6 +2833,11 @@ const translations: TranslationDeepObject<typeof en> = {
accountRequiresAttention: 'Ce compte nécessite une attention particulière',
unlock: 'Déverrouiller',
},
+ wiseGlobalReimbursementsIntro: {
+ title: 'Configurer les remboursements globaux ?',
+ subtitle: 'Payez des membres partout dans le monde dans leur devise locale.',
+ getStarted: 'Commencer',
+ },
},
addCardToDigitalWallet: {
title: ({walletName}: {walletName: string}) => `Ajouter la carte à ${walletName}`,
diff --git a/src/languages/it.ts b/src/languages/it.ts
index 9db5fb5a..dcaa0424 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -2817,6 +2817,7 @@ const translations: TranslationDeepObject<typeof en> = {
accountRequiresAttention: 'Questo conto richiede attenzione',
unlock: 'Sblocca',
},
+ wiseGlobalReimbursementsIntro: {title: 'Configurare i rimborsi globali?', subtitle: 'Paga i membri in tutto il mondo nella loro valuta locale.', getStarted: 'Inizia'},
},
addCardToDigitalWallet: {
title: ({walletName}: {walletName: string}) => `Aggiungi carta a ${walletName}`,
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index d412979f..a628acf7 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -2796,6 +2796,7 @@ const translations: TranslationDeepObject<typeof en> = {
accountRequiresAttention: 'このアカウントには対応が必要です',
unlock: 'ロック解除',
},
+ wiseGlobalReimbursementsIntro: {title: 'グローバル払い戻しを設定しますか？', subtitle: '世界中のメンバーに現地通貨で支払えます。', getStarted: '使い始める'},
},
addCardToDigitalWallet: {
title: ({walletName}: {walletName: string}) => `${walletName} にカードを追加`,
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 60718020..eca1e5ed 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -2821,6 +2821,7 @@ const translations: TranslationDeepObject<typeof en> = {
accountRequiresAttention: 'Deze account vereist aandacht',
unlock: 'Ontgrendelen',
},
+ wiseGlobalReimbursementsIntro: {title: 'Wereldwijde terugbetalingen instellen?', subtitle: 'Betaal leden wereldwijd in hun eigen lokale valuta.', getStarted: 'Aan de slag'},
},
addCardToDigitalWallet: {
title: ({walletName}: {walletName: string}) => `Kaart toevoegen aan ${walletName}`,
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index 9792f3bf..dbe07ea4 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -2855,6 +2855,7 @@ const translations: TranslationDeepObject<typeof en> = {
accountRequiresAttention: 'To konto wymaga uwagi',
unlock: 'Odblokuj',
},
+ wiseGlobalReimbursementsIntro: {title: 'Skonfigurować globalne zwroty kosztów?', subtitle: 'Płać członkom na całym świecie w ich lokalnej walucie.', getStarted: 'Zacznij'},
},
addCardToDigitalWallet: {
title: ({walletName}: {walletName: string}) => `Dodaj kartę do ${walletName}`,
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index ca2cb4c9..b0a66637 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -2812,6 +2812,7 @@ const translations: TranslationDeepObject<typeof en> = {
accountRequiresAttention: 'Esta conta precisa de atenção',
unlock: 'Desbloquear',
},
+ wiseGlobalReimbursementsIntro: {title: 'Configurar reembolsos globais?', subtitle: 'Pague membros no mundo todo na moeda local deles.', getStarted: 'Começar'},
},
addCardToDigitalWallet: {
title: ({walletName}: {walletName: string}) => `Adicionar cartão à ${walletName}`,
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index 44a092b9..b175355b 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -2722,6 +2722,7 @@ const translations: TranslationDeepObject<typeof en> = {
accountRequiresAttention: '此账户需要处理',
unlock: '解锁',
},
+ wiseGlobalReimbursementsIntro: {title: '设置全球报销？', subtitle: '按当地货币向全球成员付款。', getStarted: '开始使用'},
},
addCardToDigitalWallet: {
title: ({walletName}: {walletName: string}) => `将卡添加到 ${walletName}`,
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
e0b0f30 to
8484c7c
Compare
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
8484c7c to
0cbe359
Compare
|
@codex review |
|
@MelvinBot review this |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
WojtekBoman
changed the title
|
The code looks good overall. I found one mismatch to fix before merge and two small nits. 1. Beta-off behavior doesn't match the test steps. With the beta off, the page closes and returns to Wallet ( 2. Nits
What I checked and found fine
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0cbe359aa4
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3e5ef1620a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
🚧 joekaufmanexpensify has triggered a test Expensify/App build. You can view the workflow run here. |
| function WiseGlobalReimbursementsIntroPage({route}: WiseGlobalReimbursementsIntroPageProps) { | ||
| const bankAccountID = Number(route.params.bankAccountID); | ||
| const [bankAccountList, bankAccountListMetadata] = useOnyx(ONYXKEYS.BANK_ACCOUNT_LIST); | ||
| const [isLoadingPaymentMethods] = useOnyx(ONYXKEYS.IS_LOADING_PAYMENT_METHODS); |
There was a problem hiding this comment.
NAB. can we default this to true like WalletPage? on a cold deep link the page paints not-found for a frame before the fetch starts
| const [isLoadingPaymentMethods] = useOnyx(ONYXKEYS.IS_LOADING_PAYMENT_METHODS); | |
| const [isLoadingPaymentMethods = true] = useOnyx(ONYXKEYS.IS_LOADING_PAYMENT_METHODS); |
I have the beta & open account but still see not here page following steps |
WOOP
|
Screen.Recording.2026-10-19.at.16.01.39.mov@WojtekBoman the old button still opens corpay flow on my account with beta enabled, could we tighten the existing entry point for our beta? I'm fine to leave as is in this PR since it just adds a way to test the page, but I want to make sure that theses entry points are clearly cut with the beta. Other than that, looks great! |
I'd like to handle it in https://github.com/Expensify/Expensify/issues/692498, is it ok for you? In this PR it should be available only via deeplink as this issue is only for adding the Intro screen |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-10-19.at.14.18.21.movAndroid: mWeb ChromeScreen.Recording.2026-10-19.at.14.18.21.moviOS: HybridAppScreen.Recording.2026-10-19.at.14.13.51.moviOS: mWeb SafariScreen.Recording.2026-10-19.at.14.09.18.movMacOS: Chrome / SafariScreen.Recording.2026-10-19.at.14.06.19.mov |
melvin-bot
Bot
changed the title
|
🎯 @ZhenjaHorbach, thanks for reviewing and testing this PR! 🎉 A payment issue will be created for your review once this PR is deployed to production. If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created. |
grgia
left a comment
grgia
left a comment
There was a problem hiding this comment.
Code wise 👍
Note: We plan to do design QA when the entire flow is ready
# Conflicts: # src/libs/Navigation/types.ts
|
Intro screen LGTM and matches what I would expect 👍 
|
joekaufmanexpensify
left a comment
joekaufmanexpensify
left a comment
There was a problem hiding this comment.
NAB, is there a reason why we went with the longer Enable Global Reimbursements in the header versus just Global Reimbursements in the design doc?
|
If we want to change that, we can just do it in the next PR. |
|
🚧 grgia has triggered a test Expensify/App build. You can view the workflow run here. |
|
@joekaufmanexpensify we'll make that copy change in this PR #104366 (review) |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/grgia in version: 9.5.15-1 🚀
|
|
No help site update is needed: the new global reimbursements intro page only shows behind the |
7 participants
cc: @ZhenjaHorbach
Explanation of Change
Adds a beta-gated Wise global reimbursements intro page at
settings/wallet/:bankAccountID/global-reimbursements. Shown only for open USD business bank accounts (newisEligibleForWiseGlobalReimbursementshelper, unit tested), otherwise not-found. "Not now" returns to Wallet; "Get started" is a TODO until the next onboarding step exists. Wallet entry point comes in a follow-up PR.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/692492
PROPOSAL:
Tests
Enable the
wiseReimbursementsbeta for your accountHave an open USD business bank account in Account > Wallet and note its
bankAccountIDNavigate to
/settings/wallet/<bankAccountID>/global-reimbursementsVerify that the intro page shows the "Enable global reimbursements" header, the Earth with coins illustration, the "Set up global reimbursements?" heading, the "Pay members worldwide in their local currency." subtitle, and two buttons: "Not now" and "Get started"
Tap "Not now"
Verify that you land back on Account > Wallet
Open the page again and tap the back button in the header
Verify that you land back on Account > Wallet
With the beta enabled, navigate to
/settings/wallet/<bankAccountID>/global-reimbursementsusing the ID of a personal, non-USD, or not yet open bank account, or a non-existent IDVerify that the not-found page is shown
Disable the
wiseReimbursementsbeta and open the URL for the eligible account from the first testVerify that the page closes and you are returned to Wallet
Offline tests
N/A - the page only reads bank account data already in Onyx and makes no API calls.
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari