Skip to content

[CP both] Show Talk to a human without the beta flag - #104152

Merged
chiragsalian merged 1 commit into
mainfrom
codex/remove-talk-to-human-beta
Oct 15, 2026
Merged

chiragsalian merged 1 commit into
mainfrom
codex/remove-talk-to-human-beta

Conversation

@jasperhuangg

@jasperhuangg jasperhuangg commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

  • Makes “Talk to a human” available under Account > Help without requiring the support ticket beta.
  • Preserves the existing offline-disabled state and Concierge fallback.

Fixed Issues

N/A
PROPOSAL: N/A

Tests

Not run locally. Reviewer steps:

  1. Sign in with an account that does not have the support ticket beta enabled.
  2. Open Account > Help.
  3. Confirm “Talk to a human” is visible and opens the support flow.
  • Verify that no errors appear in the JS console

Offline tests

  1. Disconnect from the network and open Account > Help.
  2. Confirm “Talk to a human” remains visible and is disabled while offline.

QA Steps

  1. On staging, sign in with an account that does not have the support ticket beta enabled.
  2. Open Account > Help.
  3. Confirm “Talk to a human” is visible and opens the support flow.
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@jasperhuangg
jasperhuangg requested review from a team as code owners October 15, 2026 19:24
@melvin-bot
melvin-bot Bot requested review from joekaufmanexpensify and removed request for a team October 15, 2026 19:24
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-15T19:35:56.531852Z 49008ae PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@melvin-bot
melvin-bot Bot requested review from mollfpr and removed request for a team October 15, 2026 19:25
@melvin-bot

melvin-bot Bot commented Oct 15, 2026

Copy link
Copy Markdown

@mollfpr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@jasperhuangg
jasperhuangg requested review from chiragsalian and removed request for joekaufmanexpensify and mollfpr October 15, 2026 19:34
@jasperhuangg jasperhuangg changed the title Show Talk to a human without the beta flag [CP both] Show Talk to a human without the beta flag Oct 15, 2026

@chiragsalian chiragsalian left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat

@chiragsalian
chiragsalian merged commit 7e9ad84 into main Oct 15, 2026
46 of 51 checks passed
@chiragsalian
chiragsalian deleted the codex/remove-talk-to-human-beta branch October 15, 2026 19:46
@github-actions

Copy link
Copy Markdown
Contributor

🚧 chiragsalian has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify pushed a commit that referenced this pull request Oct 15, 2026
…beta

[CP both] Show Talk to a human without the beta flag

(cherry picked from commit 7e9ad84)

(cherry-picked to staging by jasperhuangg)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Oct 15, 2026
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/jasperhuangg in version: 9.5.10-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 success ✅

@MelvinBot

MelvinBot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

A help site update is needed. This PR removes the SUPPORT_TICKET beta check, so Talk to a human now appears under Account > Help for all users.

I created Docs updates for E/A#104152 Add Talk to a human option to Concierge Basics. It adds one sentence to the "Can I talk to a real person instead of Concierge?" answer in Concierge Basics, which currently says:

Absolutely. Just say you’d like to chat with a human, and we’ll connect you—24/7.

The edit adds: "You can also select Account > Help > Talk to a human."

I checked the label against src/languages/en.ts. I couldn't check it in the live UI because the test session got stuck on onboarding.

@jasperhuangg, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review


view run · view recording

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/jasperhuangg in version: 9.5.10-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

OSBotify pushed a commit that referenced this pull request Oct 15, 2026
…beta

[CP both] Show Talk to a human without the beta flag

(cherry picked from commit 7e9ad84)

(cherry-picked to production by jasperhuangg)
@MelvinBot

MelvinBot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

A help site update is needed, and the docs PR already exists: [No QA] Docs updates for E/A#104152 Add Talk to a human option to Concierge Basics. I didn't create a duplicate.

This PR removes the SUPPORT_TICKET beta check, so Talk to a human now appears under Account > Help for all users. The docs PR adds one sentence to the "Can I talk to a real person instead of Concierge?" answer in Concierge Basics: "You can also select Account > Help > Talk to a human."

This time I also checked the live UI. The Help page shows Talk to a human with the description "Get help from a real person", between Concierge and Help site. That matches the docs edit.

@jasperhuangg, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review


view run · view recording

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/cristipaval in version: 9.5.11-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/jasperhuangg in version: 9.5.12-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

MelvinBot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

A help site update is needed, and the docs PR already exists: [No QA] Docs updates for E/A#104152 Add Talk to a human option to Concierge Basics. I didn't create a duplicate.

This PR removes the SUPPORT_TICKET beta check, so Talk to a human now appears under Account > Help for all users. The docs PR adds one sentence to Concierge Basics: "You can also select Account > Help > Talk to a human."

I've now checked the label in the live UI. Account > Help shows Concierge, Talk to a human ("Get help from a real person"), and Help site, in that order.

Account > Help page showing Talk to a human

@jasperhuangg, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review


view run · view recording

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/cristipaval in version: 9.5.12-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/jasperhuangg in version: 9.5.13-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

MelvinBot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

A help site update is needed, and the docs PR already exists: [No QA] Docs updates for E/A#104152 Add Talk to a human option to Concierge Basics. I didn't create a duplicate.

This PR removes the SUPPORT_TICKET beta check, so Talk to a human now appears under Account > Help for all users. The docs PR adds one sentence to the "Can I talk to a real person instead of Concierge?" answer in Concierge Basics: "You can also select Account > Help > Talk to a human."

I confirmed the label in the live UI. The Help page lists Concierge, Talk to a human ("Get help from a real person"), and Help site.

Account > Help page showing Talk to a human

@jasperhuangg, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review


view run · view recording

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/grgia in version: 9.5.13-6 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Production CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants