Skip to content

Add Held search filter for expenses - #104076

Open
c3024 wants to merge 3 commits into
Expensify:mainfrom
c3024:chaitanya/691882-held-search-filter
Open

Add Held search filter for expenses#104076
c3024 wants to merge 3 commits into
Expensify:mainfrom
c3024:chaitanya/691882-held-search-filter

Conversation

@c3024

@c3024 c3024 commented Oct 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Explanation of Change

Adds a "Held" Yes/No filter for expenses. The query key is held:yes / held:no, and it matches expenses that are currently on hold. It works like Billable: filter list page, filter bar chip, typed query with autocomplete and negation. Hold only exists on expenses, so the filter is only offered for the Expense type.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/691882
PROPOSAL:

Tests

  1. As a member of a workspace, create three expenses on a report.
  2. Hold the first expense.
  3. Hold the second expense, then remove the hold.
  4. Go to Spend > Expenses and click Filters.
  5. Verify Held appears below Rejected.
  6. Select Held > Yes.
  7. Verify a "Held: Yes" chip appears and only the first expense is listed.
  8. Change the chip to No.
  9. Verify the second and third expenses are listed and the first is not.
  10. Go to Spend > Reports and click Filters.
  11. Verify Held is not offered.
  12. Click the search icon and type held:.
  13. Verify the suggestions are held:no and held:yes.
  14. Search for type:expense -held:yes after clicking on the Search magnifying glass icon.
  15. Verify the first expense is not listed.
  • Verify that no errors appear in the JS console

Offline tests

  1. Go offline.
  2. Click Filters on Spend > Expenses and select Held > Yes.
  3. Verify the "Held: Yes" chip appears.
  4. Go online.
  5. Verify the results load and show only held expenses.

QA Steps

Same as tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari 104076-08-expense-report-no-held 104076-06-held-autocomplete 104076-04-held-column-sort-desc 104076-03-held-no-results 104076-10-filter-bar-held-yes

@melvin-bot

melvin-bot Bot commented Oct 15, 2026

Copy link
Copy Markdown

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx bun ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx bun ./scripts/generateTranslations.ts --compare-ref main

@codecov

codecov Bot commented Oct 15, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/CONST/index.ts 95.90% <ø> (ø)
...ents/Search/FilterComponents/ListFilterContent.tsx 10.52% <ø> (ø)
src/components/Search/SearchTableHeader.tsx 48.91% <ø> (ø)
...ents/TransactionItemRow/TransactionItemRowWide.tsx 98.48% <100.00%> (+0.02%) ⬆️
src/hooks/useAdvancedSearchFilters.ts 97.29% <ø> (ø)
src/hooks/useAutocompleteSuggestions.ts 73.07% <ø> (ø)
src/libs/ReportUtils.ts 88.62% <100.00%> (-0.02%) ⬇️
src/libs/SearchParser/autocompleteParser.js 61.83% <ø> (+0.09%) ⬆️
src/libs/SearchParser/searchParser.js 85.71% <ø> (+0.06%) ⬆️
src/libs/SearchQueryUtils.ts 91.04% <100.00%> (+0.02%) ⬆️
... and 5 more
... and 9 files with indirect coverage changes

c3024 added 2 commits October 16, 2026 13:33
@c3024
Add sortable Held column for expenses
1e9cb0b
@c3024
Merge remote-tracking branch 'origin/main' into chaitanya/691882-held…
5dd03dc 
…-search-filter

# Conflicts:
#	src/CONST/index.ts
#	src/components/Search/FilterComponents/ListFilterContent.tsx
#	src/hooks/useAdvancedSearchFilters.ts
#	src/hooks/useAutocompleteSuggestions.ts
#	src/languages/de.ts
#	src/languages/el.ts
#	src/languages/en.ts
#	src/languages/es.ts
#	src/languages/fr.ts
#	src/languages/it.ts
#	src/languages/ja.ts
#	src/languages/nl.ts
#	src/languages/pl.ts
#	src/languages/pt-BR.ts
#	src/languages/zh-hans.ts
#	src/libs/SearchAutocompleteUtils.ts
#	src/libs/SearchParser/autocompleteParser.js
#	src/libs/SearchParser/autocompleteParser.peggy
#	src/libs/SearchParser/baseRules.peggy
#	src/libs/SearchParser/searchParser.js
#	src/libs/SearchParser/searchParser.peggy
#	src/libs/SearchQueryUtils.ts
#	src/libs/SearchUIUtils.ts
#	src/types/form/SearchAdvancedFiltersForm.ts
#	tests/unit/Search/SearchQueryUtilsTest.ts
#	tests/unit/SearchParserTest.ts
#	tests/unit/hooks/useAutocompleteSuggestions.test.ts
@c3024 c3024 changed the title [HOLD Auth#25515] Add Held search filter for expenses Add Held search filter for expenses Oct 20, 2026
This was referenced Oct 20, 2026
Open
Draft
@c3024
c3024 marked this pull request as ready for review October 20, 2026 05:33
@c3024
c3024 requested review from a team as code owners October 20, 2026 05:33
@melvin-bot
melvin-bot Bot requested review from JmillsExpensify and parasharrajat and removed request for a team October 20, 2026 05:33
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 20, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-20T05:49:20.507960Z 5dd03dc Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@melvin-bot
melvin-bot Bot removed the request for review from a team October 20, 2026 05:33
@melvin-bot

melvin-bot Bot commented Oct 20, 2026

Copy link
Copy Markdown

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@github-actions

github-actions Bot commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

🚧 JmillsExpensify has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

github-actions Bot commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #104076.

Android 🤖 iOS 🍎
⏩ SKIPPED ⏩ ⏩ SKIPPED ⏩
The build for Android was skipped The build for iOS was skipped
Web 🕸️
https://104076.pr-testing.expensify.com
Web

👀 View the workflow run that generated this build 👀

JmillsExpensify
JmillsExpensify approved these changes Oct 20, 2026
View reviewed changes

@JmillsExpensify JmillsExpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Excited to see this going through.

@c3024

c3024 commented Oct 21, 2026

Copy link
Copy Markdown
Contributor Author

@parasharrajat could you review this PR?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JmillsExpensify JmillsExpensify JmillsExpensify approved these changes
@parasharrajat parasharrajat Awaiting requested review from parasharrajat

Assignees

@c3024 c3024

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@c3024 @JmillsExpensify