[truph01]

Explanation of Change

Follow-up fixes for the Spend footer selectors (behind the spendFooterSelectors beta), added in #100674:

• Spend - Right chevron on Currency row is highlighted when hovered when the row is disabled #104010: the Total and Currency rows in the footer menu now hide their chevron while they are disabled (while the total reloads, and Currency while offline). Hovering a disabled row no longer highlights it.
• Spend - Save button does not disappear after resetting currency on total spend footer #104014: picking the default currency, which is what Reset does, now leaves footerCurrency out of the query. The query matches the default search again, so the Save button goes away.
• Spend - Filters selected in total spend footer are not displayed while saving a search. #104026: the Save search page lists the footer's Count, Total and Currency choices in its Display section.
• Spend - Inconsistent behavior with Total selector when reopening saved search #104031: footer keys no longer decide whether a saved search's last query is still valid. Reopening a saved search now always restores the last Total and Count choice, including the default Spend.
• Reset button is not shown when different selector is selected from footer on saved search #104030: Reset button is not shown when different selector is selected from footer on saved search

Fixed Issues

$ #104014
PROPOSAL: #104014 (comment)

$ #104010
PROPOSAL: #104010 (comment)

$ #104026
PROPOSAL: #104026 (comment)

$ #104031
PROPOSAL: #104031 (comment)

$ #104030
PROPOSAL: #104030 (comment)

Tests

Precondition: enable the spendFooterSelectors beta, and create at least one expense in a workspace chat.

#104014: Save button after resetting the currency

1. Go to Spend > Expenses.
2. Click the total spend in the footer > Currency > select any currency > Apply.
3. Click the total spend in the footer > Currency > Reset.
4. Verify the Save button next to the search field disappears.

#104010: disabled Currency row chevron

1. Go to Spend > Expenses.
2. Go offline.
3. Select the expense.
4. Click the footer.
5. Hover over Currency.
6. Verify the Currency row shows no right chevron, so nothing is highlighted on hover.

#104026: footer choices on the Save search page

1. Go to Spend > Expenses and select an expense.
2. Click the total spend in the footer > Count > Reports > Apply.
3. Click the total spend in the footer > Total > Reimbursable > Apply.
4. Click the Save button next to the search field.
5. Verify the Display section lists Count: Reports and Total: Reimbursable.

#104031: Total selector when reopening a saved search

1. Go to Spend > Expenses.
2. Click the total spend in the footer > Total > Reimbursable > Apply.
3. Click the Save button next to the search field, enter a name > Save view.
4. Go to the saved search.
5. Click the total spend in the footer > Total > Spend > Apply.
6. Go to Expenses, then go back to the saved search.
7. Verify the footer total is still Spend.
8. Click the total spend in the footer > Total > Non-reimbursable > Apply.
9. Go to Expenses, then go back to the saved search.
10. Verify the footer total is still Non-reimbursable. It behaves the same as in step 7.

#104030: Reset button is not shown when different selector is selected from footer on saved search

1. Go to Spend > Expenses (with or without a saved search open).
2. Click the footer total > Total > Billable > Apply, then Count > Reports > Apply, then Currency > any currency > Apply.
3. Verify neither Save nor Reset appears next to the search field.

• Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as test

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If the PR adds or modifies the UI:
  • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
  • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
  • I verified all new/changed elements have meaningful accessible names and roles.
  • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-10-15.at.11.19.08.mov

Screen.Recording.2026-10-15.at.11.20.01.mov

Screen.Recording.2026-10-15.at.11.20.55.mov

Screen.Recording.2026-10-15.at.11.21.26.mov

[codecov]

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/Search/SearchPageFooter.tsx	84.37% <100.00%> (ø)
src/components/Search/SearchSelectionFooter.tsx	86.11% <100.00%> (+0.12%)	⬆️
src/libs/SearchQueryUtils.ts	91.01% <100.00%> (ø)
src/libs/SearchUIUtils.ts	73.63% <100.00%> (+0.08%)	⬆️
src/pages/Search/SearchSavePage.tsx	70.40% <100.00%> (+3.74%)	⬆️
...nents/Search/FilterDropdowns/SearchFooterPopup.tsx	0.00% <0.00%> (ø)
... and 8 files with indirect coverage changes

[melvin-bot]

@mkhutornyi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-15T04:34:19.126722Z	5a4cea0	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5a4cea0f8b

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[trjExpensify]

@mkhutornyi ETA to review?

[mkhutornyi]

started

[dylanexpensify]

Looks good from a product perspective 👍

[mkhutornyi]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If the PR adds or modifies the UI:
  • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
  • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
  • I verified all new/changed elements have meaningful accessible names and roles.
  • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

104010.mov

104014.mov

104026.mov

104026-1.mov

104031.mov

[mkhutornyi]

Bug: Reports total becomes 0 when IOU report is selected

Precondition: have 1:1 IOU expense paid from another user

1. Go to Spend > Expenses and select that expense
2. Select "Count" > "Reports"
3. Observe - Reports: 1
4. Click on "Save" button > Enter name > Save
5. Observe - Reports: 0 after getting backend resposne.
6. Total also becomes plus from minus - this also happens when "Count" > "Expenses" selected

Should we exclude IOU reports from reports total calculation?

Screen.Recording.2026-10-16.at.10.11.43.AM.mov

[mkhutornyi]

Looks good. All regression issues fixed.
Just IOU case - #104058 (comment)

[truph01]

Bug: Reports total becomes 0 when IOU report is selected

@mkhutornyi I’ve fixed this via 8a5449f. IOU reports shouldn’t be counted when selected, so now the behavior for step 3 is updated from:

3. Observe - Reports: 1

to:

3. Observe - Reports: 0

[mkhutornyi]

Also, Total flips from minus to plus. It also happens with Count set to Expenses. The PR doesn't change totals, so main behaves the same. It may be worth a separate issue.

[JS00001]

@truph01 does this include the fixes for #104030 (comment)

[truph01]

@truph01 does this include the fixes for #104030 (comment)

I fixed. Now, Footer changes no longer show Save (Reset already ignored them)

[JS00001]

@mkhutornyi can you please rereview the latest changes please?

[mkhutornyi]

#104026: footer choices on the Save search page
#104031: Total selector when reopening a saved search

@truph01 I think the tests steps in these issues are no longer valid after last fix?