[lakchote]

Explanation of Change

The Campfire and Rillet help articles now use “entity,” and the DualEntry articles use “company,” matching the selector changes in #103911 and addressing the documentation portion of https://github.com/Expensify/Expensify/issues/691270.

Two configuration screenshot embeds were removed because they show the old “Subsidiary” label can you add them here @stephanieelliott?

Fixed Issues

For https://github.com/Expensify/Expensify/issues/691270
PROPOSAL:

Tests

• Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

[OSBotify]

A preview of your ExpensifyHelp changes have been deployed to https://f89a74f1.helpdot.pages.dev ⚡️

Updated articles:

• articles/new-expensify/connections/campfire/Configure-Campfire
• articles/new-expensify/connections/campfire/Connect-to-Campfire
• articles/new-expensify/connections/campfire/Export-Reports-to-Campfire
• articles/new-expensify/connections/dualentry/Configure-DualEntry
• articles/new-expensify/connections/dualentry/Connect-to-DualEntry
• articles/new-expensify/connections/dualentry/Manage-Vendor-Matching-for-DualEntry
• articles/new-expensify/connections/rillet/Configure-Rillet
• articles/new-expensify/connections/rillet/Connect-to-Rillet

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-14T14:12:44.303251Z	6d9ef84	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[github-actions]

HelpDot Documentation Review

Overall Assessment

This PR aligns accounting help articles with provider terminology changes (per PR 103911): Campfire and Rillet switch "subsidiary" to entity, and DualEntry switches "subsidiary" to company. Changes are consistent string replacements across body text, FAQ questions, YAML description, keywords, and internalScope. Two configuration screenshots showing the old Subsidiary label were removed. The changes are tightly scoped and improve UI accuracy.

Scores Summary

• Readability: 9/10 - Sentence structure, flow, and scannability are unchanged and clear. Replacements read naturally (e.g., "choose which one to connect," "scoped to the Company").
• AI Readiness: 8/10 - Metadata is updated in lockstep with body copy, including keywords and internalScope, keeping retrieval aligned to the new terms. Headings remain task/question-based (e.g., "Why cant I select a Campfire entity?"). Minor deduction: removed screenshots leave two configure articles without a visual orientation aid, which the author has flagged for follow-up.
• Style Compliance: 9/10 - Capitalization correctly distinguishes the bolded UI selector label (Entity, Company) from lowercase running-text usage (entity, company), consistent with the generic-terms rule. The DualEntry files correctly keep lowercase "company card expenses" (generic term) separate from the bolded Company selector.

Key Findings

• Terminology is applied consistently across every surface (FAQ headings, body, description, keywords, internalScope) - no stale "subsidiary" references remain in the changed lines.
• UI-label capitalization is handled correctly: bold Entity/Company when naming the selector/field, lowercase in prose.
• Two screenshots were removed (DualEntry_configure.png, Accounting_Rillet_Configure.png) because they showed the outdated Subsidiary label. The PR description explicitly asks the reviewer to supply updated images - a tracked gap, not an oversight.
• The entity vs company split per provider matches the upstream selector change, so docs now mirror the product.

Recommendations

• Add replacement screenshots for the two configure articles (DualEntry and Rillet) showing the updated selector label, as already requested in the PR description.
• No blocking style or structure issues in the diff.

Files Reviewed

• Configure-Campfire.md - subsidiary -> entity in Tax rates note. Clean.
• Connect-to-Campfire.md - subsidiary -> entity across description, keywords, internalScope, body, and FAQ. Clean.
• Export-Reports-to-Campfire.md - subsidiary -> entity in export note. Clean.
• Configure-DualEntry.md - removed outdated screenshot; terminology unchanged otherwise. Visual gap to backfill.
• Connect-to-DualEntry.md - subsidiary -> company across metadata, body, and FAQ. Clean.
• Manage-Vendor-Matching-for-DualEntry.md - subsidiary -> company incl. Company label, scoping prose, and FAQ. Clean.
• Configure-Rillet.md - removed outdated screenshot; subsidiary -> entity in Tax rates note. Visual gap to backfill.
• Connect-to-Rillet.md - subsidiary -> entity across metadata, body, and FAQ. Clean.

Note: Detailed line-by-line feedback has been provided as inline comments.

[lakchote]

cc @stephanieelliott can you take a look please?

[lakchote]

friendly bump @stephanieelliott

[stephanieelliott]

Hey @lakchote I'm hesitant to add new screenshots given the Insights nav change coming in a few days. How about we publish these articles as-is without screenshots, then I'll create a followup PR to add new ones with the Insights changes?

[stephanieelliott]

Will add the images in this PR! #102832

[OSBotify]

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.5.15-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/grgia in version: 9.5.15-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

• Android
• iOS