Repository navigation
[No QA] Docs updates for E/A#103072 Duplicate expense stays on the source report - #103851
Conversation
…t can accept expenses Co-authored-by: thelullabyy <[email protected]>
MelvinBot
added
the
HelpDot
stephanieelliott
changed the title
|
@MelvinBot Please open the PR for review |
|
@stephanieelliott I confirm that the PR changes reflect correctly current behavior, could you please review? Thanks |
|
@MelvinBot Please replace all |
|
I marked this PR as ready for review. |
Product reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR? |
|
@thelullabyy @garrettmknight One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| # How to duplicate an expense | ||
|
|
||
| You can create a copy of one or more expenses using **Duplicate expense**. This generates new expenses with the same details as the originals, including the merchant, amount, category, tags, and tax. The date is set to today and receipt images are not copied. An expense that is on a report is copied onto your primary workspace, while an Unreported expense is copied onto your personal space. | ||
| You can create a copy of one or more expenses using **Duplicate expense**. This generates new expenses with the same details as the originals, including the merchant, amount, category, tags, and tax. The date is set to today and receipt images are not copied. When you duplicate a single expense on a report you can still add expenses to, such as a Draft report, the copy is added to that same report. Otherwise, an expense that is on a report is copied onto your primary workspace, while an Unreported expense is copied onto your personal space. |
There was a problem hiding this comment.
Readability/clarity: The clause "on a report you can still add expenses to, such as a Draft report" is hard to parse (trailing preposition modifying "report") and this intro paragraph now packs three conditional branches into one run-on. Per HELP_AUTHORING_GUIDELINES.md Section 1 (concise and actionable), consider rephrasing for scannability, e.g.: "If you duplicate a single expense that is on a report still able to accept expenses (such as a Draft report), the copy stays on that report. Otherwise, an expense on a report is copied to your primary workspace, and an Unreported expense is copied to your personal space."
There was a problem hiding this comment.
Agreed the current sentence is a bit long and hard to read. The suggested change looks good.
| The duplicate expense keeps the original expense's merchant, amount, category, tags, tax, and billable or reimbursable status. The date is set to today and receipt images are not included. | ||
|
|
||
| The duplicate matches the reported state of the original. If the original expense is on a report, the copy is created on your primary workspace. If the original is an Unreported expense, the copy is created on your personal space and is not added to a report. | ||
| The duplicate matches the reported state of the original. If you duplicate a single expense on a report you can still add expenses to, such as a Draft report, the copy is added to that same report. Otherwise, if the original expense is on a report, the copy is created on your primary workspace. If the original is an Unreported expense, the copy is created on your personal space and is not added to a report. |
There was a problem hiding this comment.
Readability/clarity: "If you duplicate a single expense on a report you can still add expenses to, such as a Draft report" repeats the awkward trailing-preposition phrasing and is difficult to scan. Per HELP_AUTHORING_GUIDELINES.md Section 1 (concise and actionable), reword for clarity, e.g.: "If you duplicate a single expense on a report that can still accept expenses (such as a Draft report), the copy stays on that report."
There was a problem hiding this comment.
Otherwise, if the original expense is on a report, the copy is created on your primary workspace.
I think this is missing a description of the report state:
Otherwise, if the original expense is on a report state that cannot accept new expenses, such as Approved or Paid, the copy is created on your primary workspace.
There was a problem hiding this comment.
Updated in 47c9391. The paragraph now reads:
If you duplicate a single expense on a report that can still accept expenses (such as a Draft report), the copy stays on that report. Otherwise, if the original expense is on a report that cannot accept new expenses, such as an Approved or Paid report, the copy is created on your primary workspace.
HelpDot Documentation ReviewOverall AssessmentThis is a small, targeted copy-accuracy PR (3 changed lines across 2 files) that updates the documented behavior for duplicating an expense. Previously the docs stated a reported expense is always copied to the primary workspace; the updated copy reflects E/A#103072, where a single-expense duplicate now stays on its source report if that report can still accept expenses (for example, a Draft report), and falls back to the primary workspace otherwise. The changes are accurate, scoped to the diff, and introduce no structural, heading, or metadata changes. Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
|
I replaced every |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
@thelullabyy a few changes requested. |
|
@MelvinBot Please check and address based on these 2 below threads |
Co-authored-by: thelullabyy <[email protected]>
|
I addressed both threads in 47c9391 and replied in each one:
|
|
A preview of your ExpensifyHelp changes have been deployed to https://738773ea.helpdot.pages.dev ⚡️ Updated articles: |
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.5.15-1 🚀
|
|
🚀 Deployed to production by https://github.com/grgia in version: 9.5.15-3 🚀
Bundle Size Analysis (Sentry): |
6 participants
Explanation of Change
Help site update for #103072, which keeps a duplicated expense on its source report when that report can still accept expenses (for example, a Draft report). Before that PR, every reported expense was copied onto the primary workspace.
These sentences became incorrect:
How-to-Duplicate-an-Expense.md: "An expense that is on a report is copied onto your primary workspace, while an Unreported expense is copied onto your personal space."How-to-Duplicate-an-Expense.md: "If the original expense is on a report, the copy is created on your primary workspace."Expense-and-Report-Actions.md(Duplicate expense row): "Creates a copy of the expense on your primary workspace with the same details."Each sentence now says the copy stays on the same report when it can still accept expenses, and goes to the primary workspace otherwise. The
How-to-Duplicate-an-Expense.mdwording is limited to single-expense duplicates, because bulk Duplicate expenses still uses the primary workspace.@thelullabyy, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.Fixed Issues
$ #101327
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari