Skip to content

[Payment due @linhvovan29546] Create company agents - #103817

Merged
puneetlath merged 37 commits into
Expensify:mainfrom
s77rt:company-agent-create
Oct 20, 2026
Merged

puneetlath merged 37 commits into
Expensify:mainfrom
s77rt:company-agent-create

Conversation

@s77rt

@s77rt s77rt commented Oct 13, 2026 •

Copy link
Copy Markdown
Member

This is based on #103788 so let's merge that one first

Explanation of Change

Added option to create company agents in Workspace > Agents page

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/681638
PROPOSAL:

Tests

  • Have a workspace
  1. Go to Workspace > Agents
  2. Click on New agent and create an agent
  3. Verify the agent is created
  4. Verify the agent is added to the workspace with the chosen role
  5. Go to Settings > Agents
  6. Verify the agent is listed there too
  7. Verify the agent owner is either the policy account or domain account (and not your account)
Screen.Recording.2026-10-19.at.2.14.00.PM.mov
  • Verify that no errors appear in the JS console

Offline tests

Same as Tests except steps 4 and 7

QA Steps

Same as Tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@codecov

codecov Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
...s/Search/SearchRouter/useNavigationSuggestions.tsx 93.39% <ø> (ø)
src/hooks/useWorkspaceMembers.ts 89.28% <ø> (ø)
src/libs/API/types.ts 100.00% <ø> (ø)
src/libs/actions/Agent.ts 74.00% <100.00%> (+1.95%) ⬆️
src/pages/settings/Agents/DynamicNewAgentPage.tsx 98.70% <100.00%> (+0.09%) ⬆️
src/pages/workspace/WorkspaceInitialPage.tsx 86.36% <100.00%> (+0.12%) ⬆️
src/pages/workspace/getWorkspaceMenuItems.ts 98.50% <100.00%> (+0.01%) ⬆️
src/types/form/AddAgentForm.ts 100.00% <ø> (ø)
...ppNavigator/Navigators/WorkspaceSplitNavigator.tsx 7.69% <0.00%> (ø)
src/pages/settings/Agents/DynamicAddAgentPage.tsx 91.96% <95.55%> (-0.67%) ⬇️
... and 3 more
... and 61 files with indirect coverage changes

@s77rt s77rt changed the title Create company agents [Hold Web-E#57060] Create company agents Oct 13, 2026
@s77rt
s77rt marked this pull request as ready for review October 13, 2026 04:36
@s77rt
s77rt requested review from a team as code owners October 13, 2026 04:36
@melvin-bot
melvin-bot Bot requested review from brunovjk and trjExpensify and removed request for a team October 13, 2026 04:36
@melvin-bot

melvin-bot Bot commented Oct 13, 2026

Copy link
Copy Markdown

@brunovjk Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed request for a team and trjExpensify October 13, 2026 04:36
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-13T04:57:32.739598Z 1c1378f Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@s77rt
s77rt requested review from linhvovan29546 and removed request for brunovjk October 13, 2026 04:37
Comment thread src/hooks/useWorkspaceMembers.ts
Comment thread src/components/Tables/AgentsTable/index.tsx
Comment thread src/components/Tables/AgentsTable/index.tsx
Comment thread src/components/Tables/AgentsTable/index.tsx
Comment thread src/components/Tables/AgentsTable/index.tsx
Comment thread src/components/Tables/AgentsTable/AgentsTableRow.tsx
@s77rt
s77rt requested a review from linhvovan29546 October 20, 2026 09:52
@melvin-bot
melvin-bot Bot requested a review from puneetlath October 20, 2026 12:12
@melvin-bot melvin-bot Bot changed the title Create company agents [Payment due @linhvovan29546] Create company agents Oct 20, 2026
@melvin-bot

melvin-bot Bot commented Oct 20, 2026

Copy link
Copy Markdown

🎯 @linhvovan29546, thanks for reviewing and testing this PR! 🎉

A payment issue will be created for your review once this PR is deployed to production.
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/681638.

If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created.

@puneetlath puneetlath left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Should we have the design team review as well?

@s77rt

s77rt commented Oct 20, 2026

Copy link
Copy Markdown
Member Author

cc @Expensify/design

@s77rt

s77rt commented Oct 20, 2026 •

Copy link
Copy Markdown
Member Author

@puneetlath Let's actually merge this. I will handle any reviews here in the next PR

@puneetlath
puneetlath merged commit 778b5af into Expensify:main Oct 20, 2026
38 of 40 checks passed
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

Copy link
Copy Markdown
Contributor

🚧 puneetlath has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/puneetlath in version: 9.5.16-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update needed. The only new user-facing feature is creating company agents from Workspace > Agents, and only users with the companyAgents beta can see it. The Agents menu item is gated in getWorkspaceMenuItems.ts:260, and the page is blocked without the beta in WorkspaceAgentsPage.tsx:133. Personal agents in Settings > Agents work the same as before, so no existing article is now wrong. You can revisit the docs when the companyAgents beta is removed.


view run

@mitarachim

Copy link
Copy Markdown

Deploy Blocker #104647 was identified to be related to this PR.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/puneetlath in version: 9.5.18-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 cancelled 🔪

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update needed: the new Workspace > Agents page where you create company agents only appears behind the COMPANY_AGENTS beta (isBetaEnabled(CONST.BETAS.COMPANY_AGENTS) in getWorkspaceMenuItems.ts and WorkspaceAgentsPage.tsx), and the personal agent flow in Settings > Agents works the same for users as before.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/grgia in version: 9.5.18-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@melvin-bot

melvin-bot Bot commented Oct 23, 2026

Copy link
Copy Markdown

🤖 Payment issue created: #104871

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants