Skip to content

Revert "Return to the intent list from work email Back after a refresh" - #103646

Closed
carlosmiceli wants to merge 1 commit into
mainfrom
revert-103532-claude-fixOnboardingWorkEmailBackAfterRefresh
Closed

carlosmiceli wants to merge 1 commit into
mainfrom
revert-103532-claude-fixOnboardingWorkEmailBackAfterRefresh

Conversation

@carlosmiceli

Copy link
Copy Markdown
Contributor

Reverts #103532

@carlosmiceli carlosmiceli self-assigned this Oct 9, 2026
@carlosmiceli
carlosmiceli requested review from a team as code owners October 9, 2026 18:45
@melvin-bot
melvin-bot Bot requested review from garrettmknight and removed request for a team October 9, 2026 18:45
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-09T18:55:57.186037Z c4ae144 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@melvin-bot
melvin-bot Bot requested review from grgia and removed request for a team October 9, 2026 18:46
@melvin-bot

melvin-bot Bot commented Oct 9, 2026

Copy link
Copy Markdown

@grgia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c4ae144ed5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

<OnboardingHeader
shouldShowBackButton={isJoiningCompanyWorkspace && !isConciergeTaskFlow}
onBackButtonPress={() => Navigation.goBack(ROUTES.ONBOARDING_PURPOSE.getRoute())}
onBackButtonPress={() => Navigation.goBack()}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve the intent-list fallback after a refresh

When a user selects “Join a workspace” and then refreshes on the work-email URL, deep-link reconstruction leaves only WORK_EMAIL in the onboarding stack. Calling bare goBack() therefore pops the entire onboarding modal instead of returning to the purpose screen, so the visible Back button can take an incomplete-onboarding user out of the flow. Keep ROUTES.ONBOARDING_PURPOSE as the fallback so Back replaces the current route when the purpose screen is no longer in the stack.

Useful? React with 👍 / 👎.

@grgia

grgia commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

already reverted on main?

@puneetlath

Copy link
Copy Markdown
Contributor

Yes, I believe this was reverted, and we can close this PR out, right @carlosmiceli?

@carlosmiceli

Copy link
Copy Markdown
Contributor Author

Yup!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants